[CI] Fix coverage build and codecov stats by christophfroehlich · Pull Request #804 · ros-controls/ros2_controllers

christophfroehlich · 2023-10-22T15:56:47Z

The Codecov stats were only evaluated for diff_drive_controller, see old vs new.
The test folders have very low coverage (why?). I excluded them from the statistics as I don't think it makes sense to include them.

.github/workflows/ci-coverage-build.yml

codecov · 2023-10-22T17:12:24Z

Codecov Report

Merging #804 (43c30ad) into master (22356e0) will increase coverage by 14.36%.
The diff coverage is n/a.

Additional details and impacted files

@@             Coverage Diff             @@
##           master     #804       +/-   ##
===========================================
+ Coverage   30.88%   45.25%   +14.36%     
===========================================
  Files           7       40       +33     
  Lines         832     3666     +2834     
  Branches      505     1732     +1227     
===========================================
+ Hits          257     1659     +1402     
- Misses        133      823      +690     
- Partials      442     1184      +742

Flag	Coverage Δ
unittests	`45.25% <ø> (+14.36%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 37 files with indirect coverage changes

.github/workflows/ci-coverage-build.yml

christophfroehlich · 2023-10-22T20:56:35Z

idk why the CI job fails, something is happening with joint_state_broadcaster.

bmagyar · 2023-10-22T22:52:15Z

We don't test the tests enough, right? ;)

christophfroehlich · 2023-10-23T05:50:22Z

and the flaky tests now also affect the coverage build :/

bmagyar · 2023-10-23T21:04:07Z

Could the codecov builds be very different? Or only the environment? Something is making some tests flakier than they usually are

christophfroehlich · 2023-10-24T12:44:22Z

I'm not sure, but I have to save that 😁

christophfroehlich · 2023-10-24T12:57:02Z

Could the codecov builds be very different? Or only the environment? Something is making some tests flakier than they usually are

ros-tooling/action-ros-ci vs ros-industrial/industrial_ci
maybe the mixin makes a totally different build

ros2_controllers/.github/workflows/ci-coverage-build.yml

Lines 36 to 41 in 22356e0

    
                     colcon-defaults: | 
        
                       { 
        
                         "build": { 
        
                           "mixin": ["coverage-gcc"] 
        
                         } 
        
                       }

bmagyar · 2023-10-24T18:16:16Z

I'm not sure, but I have to save that 😁

Top contributor of the year

bmagyar · 2023-10-24T18:16:52Z

Could the codecov builds be very different? Or only the environment? Something is making some tests flakier than they usually are

ros-tooling/action-ros-ci vs ros-industrial/industrial_ci maybe the mixin makes a totally different build

ros2_controllers/.github/workflows/ci-coverage-build.yml

Lines 36 to 41 in 22356e0

colcon-defaults: |

{

"build": {

"mixin": ["coverage-gcc"]

}

}

Maybe. But it's green now so I'll merge it quickly:D

Squashed commit of the following: commit 0a9f4b0 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Nov 16 23:17:20 2023 +0000 Bump ros-tooling/action-ros-ci from 0.3.4 to 0.3.5 (ros-controls#833) commit 3fc0f50 Author: Christoph Fröhlich <christophfroehlich@users.noreply.github.com> Date: Wed Nov 15 20:03:40 2023 +0100 [JTC] Activate update of dynamic parameters (ros-controls#761) commit b13ae5b Author: Christoph Fröhlich <christophfroehlich@users.noreply.github.com> Date: Wed Nov 15 19:14:09 2023 +0100 [JTC] Fix tests when state offset is used (ros-controls#797) * Simplify initialization of states * Rename read_state_from_hardware method * Don't set state_desired in on_activate --------- Co-authored-by: Dr. Denis <denis@stoglrobotics.de> commit f1a5397 Author: Christoph Fröhlich <christophfroehlich@users.noreply.github.com> Date: Wed Nov 15 12:18:38 2023 +0100 [JTC] Remove deprecation warnings, set `allow_nonzero_velocity_at_trajectory_end` default false (ros-controls#834) commit 232154d Author: Christoph Fröhlich <christophfroehlich@users.noreply.github.com> Date: Sat Nov 11 15:30:19 2023 +0100 [CI] Update coverage workflows and some cleanup (ros-controls#819) * Add CI coverage jobs for humble and iron * Add all packages to source build * Update repos files * Build ros-control packages from source * use humble job names Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com> --------- Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com> commit 0196eeb Author: Tony Baltovski <tony.baltovski@gmail.com> Date: Thu Nov 9 17:15:45 2023 -0500 [diff_drive_controller] Fixed typos in diff_drive_controller_parameter.yaml. (ros-controls#822) commit 71ec842 Author: Christoph Fröhlich <christophfroehlich@users.noreply.github.com> Date: Tue Nov 7 13:47:23 2023 +0100 [CI] Re-add humble workflow files and add iron to readme (ros-controls#818) commit 9d4ea6b Author: Bence Magyar <bence.magyar.robotics@gmail.com> Date: Tue Nov 7 12:01:23 2023 +0000 [diff_drive_controller] Remove non-stamped Twist option (ros-controls#812) commit 5f78fe4 Author: Bence Magyar <bence.magyar.robotics@gmail.com> Date: Tue Nov 7 12:01:02 2023 +0000 Adjust tests after passing URDF to controllers (ros-controls#817) commit 2c6d7a6 Author: Bence Magyar <bence.magyar.robotics@gmail.com> Date: Mon Nov 6 18:29:10 2023 +0000 Add iron branch (ros-controls#814) commit f81a82c Author: Christoph Fröhlich <christophfroehlich@users.noreply.github.com> Date: Fri Nov 3 21:18:31 2023 +0100 [CI] Codecov (ros-controls#807) commit c6ecab7 Author: Bence Magyar <bence.magyar.robotics@gmail.com> Date: Wed Nov 1 21:38:16 2023 +0000 Use pre-commit fork of clang-format instead of local (ros-controls#813) commit 6e46053 Author: Bence Magyar <bence.magyar.robotics@gmail.com> Date: Tue Oct 31 21:34:10 2023 +0000 3.17.0 commit 822552f Author: Bence Magyar <bence.magyar.robotics@gmail.com> Date: Tue Oct 31 21:33:40 2023 +0000 Update changelogs commit 8a90b51 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Oct 31 20:27:04 2023 +0000 Bump ros-tooling/action-ros-ci from 0.3.3 to 0.3.4 (ros-controls#810) commit b65314d Author: Christoph Fröhlich <christophfroehlich@users.noreply.github.com> Date: Thu Oct 26 12:09:27 2023 +0200 Cleanup comments and unnecessary checks (ros-controls#803) commit b36b9d2 Author: Christoph Fröhlich <christophfroehlich@users.noreply.github.com> Date: Tue Oct 24 20:17:28 2023 +0200 [CI] Fix coverage build and codecov stats (ros-controls#804) commit 22356e0 Author: Dr. Denis <denis@stoglrobotics.de> Date: Mon Oct 16 18:49:47 2023 +0200 [TestNodes] Optimize output about setup of JTC publisher (ros-controls#792) commit ac291ab Author: Christoph Fröhlich <christophfroehlich@users.noreply.github.com> Date: Mon Oct 16 13:00:53 2023 +0200 Steering controllers library: fix open loop mode (ros-controls#793) * set last*velocity variables for open loop odometry * Make function arguments const * Update function in header file too commit c831b6c Author: Christoph Fröhlich <christophfroehlich@users.noreply.github.com> Date: Mon Oct 16 12:58:44 2023 +0200 Update requirements of state interfaces (ros-controls#798)

Run coverage build on meta_package

464d4a5

github-actions bot requested review from VX792, anfemosa, aprotyas, bmagyar, destogl, duringhof and progtologist October 22, 2023 15:57

Give package names explicitely

9d9c8d9

christophfroehlich commented Oct 22, 2023

View reviewed changes

.github/workflows/ci-coverage-build.yml Outdated Show resolved Hide resolved

Fix format

7a66260

Ignore test subfolders from codecov

4aa06e4

christophfroehlich changed the title ~~[CI] Run coverage build on meta_package~~ [CI] Fix coverage build and codecov stats Oct 22, 2023

christophfroehlich commented Oct 22, 2023

View reviewed changes

.github/workflows/ci-coverage-build.yml Outdated Show resolved Hide resolved

Update .github/workflows/ci-coverage-build.yml

43c30ad

bmagyar approved these changes Oct 24, 2023

View reviewed changes

bmagyar merged commit b36b9d2 into ros-controls:master Oct 24, 2023

christophfroehlich mentioned this pull request Oct 30, 2023

[CI] codecov updates ros-controls/ros2_control#1147

Merged

christophfroehlich deleted the patch-2 branch November 15, 2023 17:10

christophfroehlich mentioned this pull request Nov 17, 2023

Ignore test code for codecov #844

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CI] Fix coverage build and codecov stats#804

[CI] Fix coverage build and codecov stats#804
bmagyar merged 5 commits intoros-controls:masterfrom
christophfroehlich:patch-2

christophfroehlich commented Oct 22, 2023 •

edited

Loading

Uh oh!

Uh oh!

codecov bot commented Oct 22, 2023 •

edited

Loading

Uh oh!

Uh oh!

christophfroehlich commented Oct 22, 2023

Uh oh!

bmagyar commented Oct 22, 2023

Uh oh!

christophfroehlich commented Oct 23, 2023

Uh oh!

bmagyar commented Oct 23, 2023

Uh oh!

christophfroehlich commented Oct 24, 2023

Uh oh!

christophfroehlich commented Oct 24, 2023

Uh oh!

bmagyar commented Oct 24, 2023

Uh oh!

bmagyar commented Oct 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

christophfroehlich commented Oct 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Oct 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

christophfroehlich commented Oct 22, 2023

Uh oh!

bmagyar commented Oct 22, 2023

Uh oh!

christophfroehlich commented Oct 23, 2023

Uh oh!

bmagyar commented Oct 23, 2023

Uh oh!

christophfroehlich commented Oct 24, 2023

Uh oh!

christophfroehlich commented Oct 24, 2023

Uh oh!

bmagyar commented Oct 24, 2023

Uh oh!

bmagyar commented Oct 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

christophfroehlich commented Oct 22, 2023 •

edited

Loading

codecov bot commented Oct 22, 2023 •

edited

Loading