Relax the version compatibility for urdfdom_headers.#222
Conversation
That is, newer versions of urdfdom_headers should be just fine, so don't specify a version here. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
|
This should also hopefully fix the failing build in https://build.ros2.org/job/Rbin_uN64__urdfdom__ubuntu_noble_amd64__binary/19/console |
|
Pulls: #222
|
fujitatomoya
left a comment
There was a problem hiding this comment.
@clalancette thanks! fix looks good to me, now local build in progress. i will let you know the result as soon as i see it.
|
local (source build with ros2/ros2@58faf9a on Uuntu Noble) build passes. |
Thanks for the confirmation! Once CI finishes here I will merge and release. |
|
Sigh. Infrastructure on regular Linux has been quite challenging; it's had to restart at least twice today. While I would be highly surprised if Linux amd64 failed where Linux arm64 succeeded, I'm still going to try to let Linux amd64 run to completion before merging it. Which likely means I will merge and release tomorrow instead. |
|
@clalancette CI failures are unrelated, is this good to merge? i do not have power... |
That is, newer versions of urdfdom_headers should be just fine, so don't specify a version here.
This should fix ros2/ros2#1705
@fujitatomoya Since I can't reproduce this, can you give this PR a try and see if it fixes things for you?