Skip to content

add libboost-regex-dev key#23620

Merged
tfoote merged 2 commits intoros:masterfrom
mikaelarguedas:boost-regex
Jan 28, 2020
Merged

add libboost-regex-dev key#23620
tfoote merged 2 commits intoros:masterfrom
mikaelarguedas:boost-regex

Conversation

@mikaelarguedas
Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
@gavanderhoorn
Copy link
Copy Markdown
Contributor

rosdep/base.yaml Outdated
ubuntu: [libboost-random-dev]
libboost-regex-dev:
debian: [libboost-regex-dev]
fedora: [boost-regex]
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The boost-regex package contains only the runtime library. All boost development files (including headers and linkable libraries) are provided by boost-devel. Since the Ubuntu package you're referencing here contains those development files, you should use boost-devel here.

Suggested change
fedora: [boost-regex]
fedora: [boost-devel]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cottsay: so there is no way to install only the devel part for a particular Boost library on Fedora?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh my bad I was copying the other boost entries. Thanks!

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the other boost entries accordingly in #23624

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so there is no way to install only the devel part for a particular Boost library on Fedora?

Correct - only the runtime libraries are broken out into individual packages, which doesn't typically help us here because we don't typically take a runtime dependency in a package.xml if we take a devel dependency for building...

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I completely understand your last comment there, but the context in which this PR is submitted: Generating ‘dev’ and runtime artefacts from ROS packages.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That exactly describes the behavior I was (poorly) trying to describe above as atypical.

@mikaelarguedas - #23624 looks right at a glance - I can take a closer look in the A.M.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cottsay friendly 🛎️ in case it fell off the plate. Is it possible to get #23624 reviewed/merged?

Co-Authored-By: Scott K Logan <logans@cottsay.net>
@clalancette clalancette added the rosdep Issue/PR is for a rosdep key label Jan 27, 2020
@tfoote tfoote merged commit 97c5c68 into ros:master Jan 28, 2020
@mikaelarguedas mikaelarguedas deleted the boost-regex branch January 28, 2020 08:41
at-wat pushed a commit to alpine-ros/rosdistro that referenced this pull request Mar 12, 2020
* add libboost-regex-dev key

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>

* use boost-devel to get headers

Co-Authored-By: Scott K Logan <logans@cottsay.net>

Co-authored-by: Scott K Logan <logans@cottsay.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rosdep Issue/PR is for a rosdep key

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants