add and fix boost rules by mikaelarguedas · Pull Request #23624 · ros/rosdistro

mikaelarguedas · 2020-01-27T10:39:19Z

Based on #23620 (comment) most fedora rules for libboost-*-dev were wrong.

This PR:

fix dev boost keys for fedora
add non-dev boost keys for all existing dev boost keys
add libboost-atomic and libboost-atomic-dev

Links:

Fedora
https://apps.fedoraproject.org/packages/boost-devel
https://apps.fedoraproject.org/packages/boost-atomic
https://apps.fedoraproject.org/packages/boost-chrono
https://apps.fedoraproject.org/packages/boost-date-time
https://apps.fedoraproject.org/packages/boost-filesystem
https://apps.fedoraproject.org/packages/boost-iostreams
https://apps.fedoraproject.org/packages/boost-program-options
https://apps.fedoraproject.org/packages/boost-random
https://apps.fedoraproject.org/packages/boost-system
https://apps.fedoraproject.org/packages/boost-thread
libboost-atomic:
- Ubuntu
  - xenial: https://packages.ubuntu.com/xenial/libboost-atomic1.58.0
  - bionic: https://packages.ubuntu.com/bionic/libboost-atomic1.65.1
  - eoan/focal: https://packages.ubuntu.com/eoan/libboost-atomic1.67.0
- Debian
  - buster: https://packages.debian.org/buster/libboost-atomic1.67.0
  - stretch: https://packages.debian.org/stretch/libboost-atomic1.62.0
libboost-atomic-dev:
- Ubuntu: https://packages.ubuntu.com/xenial/libboost-atomic-dev
- Debian: https://packages.debian.org/buster/libboost-atomic-dev
libboost-chrono:
- Ubuntu
  - xenial: https://packages.ubuntu.com/xenial/libboost-chrono1.58.0
  - bionic: https://packages.ubuntu.com/bionic/libboost-chrono1.65.1
  - eoan/focal: https://packages.ubuntu.com/eoan/libboost-chrono1.67.0
- Debian
  - buster: https://packages.debian.org/buster/libboost-chrono1.67.0
  - stretch: https://packages.debian.org/stretch/libboost-chrono1.62.0
libboost-date-time:
- Ubuntu
  - xenial: https://packages.ubuntu.com/xenial/libboost-date-time1.58.0
  - bionic: https://packages.ubuntu.com/bionic/libboost-date-time1.65.1
  - eoan/focal: https://packages.ubuntu.com/eoan/libboost-date-time1.67.0
- Debian
  - buster: https://packages.debian.org/buster/libboost-date-time1.67.0
  - stretch: https://packages.debian.org/stretch/libboost-date-time1.62.0
libboost-filesystem:
- Ubuntu
  - xenial: https://packages.ubuntu.com/xenial/libboost-filesystem1.58.0
  - bionic: https://packages.ubuntu.com/bionic/libboost-filesystem1.65.1
  - eoan/focal: https://packages.ubuntu.com/eoan/libboost-filesystem1.67.0
- Debian
  - buster: https://packages.debian.org/buster/libboost-filesystem1.67.0
  - stretch: https://packages.debian.org/stretch/libboost-filesystem1.62.0
libboost-iostreams:
- Ubuntu
  - xenial: https://packages.ubuntu.com/xenial/libboost-iostreams1.58.0
  - bionic: https://packages.ubuntu.com/bionic/libboost-iostreams1.65.1
  - eoan/focal: https://packages.ubuntu.com/eoan/libboost-iostreams1.67.0
- Debian
  - buster: https://packages.debian.org/buster/libboost-iostreams1.67.0
  - stretch: https://packages.debian.org/stretch/libboost-iostreams1.62.0
libboost-program-options:
- Ubuntu
  - focal: https://packages.ubuntu.com/focal/libboost-program-options1.67.0
- Debian
  - buster: https://packages.debian.org/buster/libboost-program-options1.67.0
libboost-random:
- Ubuntu
  - xenial: https://packages.ubuntu.com/xenial/libboost-random1.58.0
  - focal: https://packages.ubuntu.com/focal/libboost-random1.67.0
- Debian
  - buster: https://packages.debian.org/buster/libboost-random1.67.0
libboost-system:
- Ubuntu
  - trusty: https://packages.ubuntu.com/trusty/libboost-system1.55.0
  - xenial: https://packages.ubuntu.com/xenial/libboost-system1.58.0
  - bionic: https://packages.ubuntu.com/bionic/libboost-system1.65.1
  - disco: https://packages.ubuntu.com/disco/libboost-system1.67.0
  - eoan/focal: https://packages.ubuntu.com/eoan/libboost-system1.67.0
- Debian
  - buster: https://packages.debian.org/buster/libboost-system1.67.0
  - stretch: https://packages.debian.org/stretch/libboost-system1.62.0
libboost-thread:
- Ubuntu
  - trusty: https://packages.ubuntu.com/trusty/libboost-thread1.55.0
  - xenial: https://packages.ubuntu.com/xenial/libboost-thread1.58.0
  - bionic: https://packages.ubuntu.com/bionic/libboost-thread1.65.1
  - disco: https://packages.ubuntu.com/disco/libboost-thread1.67.0
  - eoan/focal: https://packages.ubuntu.com/eoan/libboost-thread1.67.0
- Debian
  - buster: https://packages.debian.org/buster/libboost-thread1.67.0
  - stretch: https://packages.debian.org/stretch/libboost-thread1.62.0

gavanderhoorn · 2020-01-27T12:13:11Z

Beat me to it. Thanks 👍

tfoote · 2020-01-28T04:09:58Z

This looks reasonable but it needs a rebase now

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>

mikaelarguedas · 2020-01-28T09:06:54Z

Rebased on top of #23622 to avoid conflicting again when #23622 gets in.

fix dev boost keys for fedora add non-dev boost keys for all existing dev boost keys add libboost-atomic and libboost-atomic-dev Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>

mikaelarguedas · 2020-01-28T09:13:28Z

libboost-regex links

Ubuntu
- xenial: https://packages.ubuntu.com/xenial/libboost-regex1.58.0
- bionic: https://packages.ubuntu.com/bionic/libboost-regex1.65.1
- eoan/focal: https://packages.ubuntu.com/eoan/libboost-regex1.67.0
Debian
buster: https://packages.debian.org/buster/libboost-regex1.67.0
stretch: https://packages.debian.org/stretch/libboost-regex1.62.0

gavanderhoorn · 2020-02-03T08:34:44Z

Friendly 🛎️

Is there anything holding this back?

nuclearsandwich · 2020-02-05T18:04:10Z

bellhop_bell

Is there anything holding this back?

I meant to review this yesterday and got caught up trying to get the other PR merged in cleanly before being pulled away. I'll try to get a second review on this today.

rosbuild · 2020-02-05T18:25:30Z

This pull request has been mentioned on ROS. There might be relevant details there:

https://discourse.ros.org/t/new-github-integration-with-ros-discourse/12627/1

nuclearsandwich · 2020-02-06T00:06:32Z

I, for one, welcome our new well-scoped dependency overlords.

rosbuild · 2020-02-06T10:27:49Z

This pull request has been mentioned on ROS. There might be relevant details there:

https://discourse.ros.org/t/generating-dev-and-runtime-artefacts-from-ros-packages/12448/23

* add libboost-dev key Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com> * add and fix boost keys fix dev boost keys for fedora add non-dev boost keys for all existing dev boost keys add libboost-atomic and libboost-atomic-dev Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>

gavanderhoorn · 2020-04-27T14:10:26Z

@mikaelarguedas: any reason you did not include libboost-math? It's only available on Bionic and later, but there are other keys like that.

mikaelarguedas · 2020-04-27T16:05:07Z

I simply replaced the ones already existing in the rosdep database and didnt add new ones. So my guess is that it wasn't in the database when I made this PR.

Rereading the description it looks like I added libboost-atomic(-dev), it must have been because some ros_core packages depended on it so I needed to add it to update those packages. There are likely multiple boost packages that still dont have a rosdep key

ruffsl · 2020-05-07T01:33:08Z

In addition to libboost-math(-dev), could we add:

libboost-timer(-dev)
libboost-serialization(-dev)

mikaelarguedas requested a review from a team as a code owner January 27, 2020 10:39

mikaelarguedas mentioned this pull request Jan 27, 2020

add libboost-regex-dev key #23620

Merged

clalancette added the rosdep Issue/PR is for a rosdep key label Jan 27, 2020

add libboost-dev key

2982221

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>

mikaelarguedas force-pushed the fix_boost_fedora branch from f63cc2a to 8c51fbe Compare January 28, 2020 09:04

mikaelarguedas mentioned this pull request Jan 28, 2020

add libboost-dev key #23622

Merged

add and fix boost keys

5fdc840

fix dev boost keys for fedora add non-dev boost keys for all existing dev boost keys add libboost-atomic and libboost-atomic-dev Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>

mikaelarguedas force-pushed the fix_boost_fedora branch from 8c51fbe to 5fdc840 Compare January 28, 2020 09:10

tfoote approved these changes Jan 30, 2020

View reviewed changes

gavanderhoorn mentioned this pull request Jan 30, 2020

Be specific about which parts of Boost are necessary ros-drivers/transport_drivers#10

Merged

tfoote requested a review from a team February 5, 2020 00:37

nuclearsandwich approved these changes Feb 6, 2020

View reviewed changes

nuclearsandwich merged commit bb2ba3f into ros:master Feb 6, 2020

mikaelarguedas deleted the fix_boost_fedora branch February 6, 2020 07:36

mikaelarguedas mentioned this pull request Feb 22, 2020

Remove blanket dependency on boost? ros2/rosbag2_bag_v2#24

Open

mikaelarguedas mentioned this pull request Jul 30, 2020

add libboost-{math,timer,serialization} keys #25995

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add and fix boost rules#23624

add and fix boost rules#23624
nuclearsandwich merged 2 commits intoros:masterfrom
mikaelarguedas:fix_boost_fedora

mikaelarguedas commented Jan 27, 2020

Uh oh!

gavanderhoorn commented Jan 27, 2020

Uh oh!

tfoote commented Jan 28, 2020

Uh oh!

mikaelarguedas commented Jan 28, 2020

Uh oh!

mikaelarguedas commented Jan 28, 2020

Uh oh!

gavanderhoorn commented Feb 3, 2020

Uh oh!

nuclearsandwich commented Feb 5, 2020

Uh oh!

rosbuild commented Feb 5, 2020

Uh oh!

nuclearsandwich commented Feb 6, 2020 •

edited

Loading

Uh oh!

rosbuild commented Feb 6, 2020

Uh oh!

gavanderhoorn commented Apr 27, 2020

Uh oh!

mikaelarguedas commented Apr 27, 2020

Uh oh!

ruffsl commented May 7, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

mikaelarguedas commented Jan 27, 2020

Links:

Uh oh!

gavanderhoorn commented Jan 27, 2020

Uh oh!

tfoote commented Jan 28, 2020

Uh oh!

mikaelarguedas commented Jan 28, 2020

Uh oh!

mikaelarguedas commented Jan 28, 2020

Uh oh!

gavanderhoorn commented Feb 3, 2020

Uh oh!

nuclearsandwich commented Feb 5, 2020

Uh oh!

rosbuild commented Feb 5, 2020

Uh oh!

nuclearsandwich commented Feb 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rosbuild commented Feb 6, 2020

Uh oh!

gavanderhoorn commented Apr 27, 2020

Uh oh!

mikaelarguedas commented Apr 27, 2020

Uh oh!

ruffsl commented May 7, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

nuclearsandwich commented Feb 6, 2020 •

edited

Loading