Skip to content

Depend on generic libcurl-dev#15308

Merged
dirk-thomas merged 1 commit intoros:masterfrom
jspricke:fix_curl
Jun 6, 2018
Merged

Depend on generic libcurl-dev#15308
dirk-thomas merged 1 commit intoros:masterfrom
jspricke:fix_curl

Conversation

@jspricke
Copy link
Copy Markdown
Member

Don't depend on specific openssl version, as this could conflict with an
already installed gnutls version.

Don't depend on specific openssl version, as this could conflict with an
already installed gnutls version.
@mikaelarguedas
Copy link
Copy Markdown
Member

@jspricke I couldn't find libcurl-dev on either package.debian.org or packages.ubuntu.com, could you clarify where you found those packages names ?

@jspricke
Copy link
Copy Markdown
Member Author

@mikaelarguedas
Copy link
Copy Markdown
Member

oh interesting that the search doesn't return virtual packages o_O. Thanks for the links.
I think that virtual packages are now handled by rosdep so this shouldn't be a blocker for the change. I'll let @tfoote and @dirk-thomas review this though.

dirk-thomas
dirk-thomas previously approved these changes Jun 21, 2017
@dirk-thomas dirk-thomas dismissed their stale review June 21, 2017 15:46

I actually couldn't make it work easily while trying it. I will leave it up to @tfoote to try / confirm / approve / merge.

@tfoote
Copy link
Copy Markdown
Member

tfoote commented Jun 26, 2017

It does look like this is a problem. I think we resolved the virtual package checks but it doesn't appear that we've resolved the install side issues:

This is what rosdep would have run:

tfoote@snowman:~ Last: [0] (1s Seconds)
$ rosdep install -s resource_retriever --reinstall
#[apt] Installation commands:
  sudo -H apt-get install python-rospkg
  sudo -H apt-get install ros-kinetic-rosconsole
  sudo -H apt-get install libcurl4-openssl-dev
  sudo -H apt-get install curl
  sudo -H apt-get install ros-kinetic-roslib
  sudo -H apt-get install ros-kinetic-catkin

I tweaked it to use the new rule and it failed to install.

tfoote@snowman:~ Last: [0] (0s Seconds)
$ sudo -H apt-get install libcurl-dev
Reading package lists... Done
Building dependency tree       
Reading state information... Done
Package libcurl-dev is a virtual package provided by:
  libcurl4-openssl-dev 7.47.0-1ubuntu2.2
  libcurl4-nss-dev 7.47.0-1ubuntu2.2
  libcurl4-gnutls-dev 7.47.0-1ubuntu2.2
You should explicitly select one to install.

E: Package 'libcurl-dev' has no installation candidate

We've previously tried the same: #57 but had to revert #58

It looks like we haven't resolved being able to install.

I think ros-infrastructure/rosdep#274 needs to be reopened wrt to installing.

@mathias-luedtke
Copy link
Copy Markdown
Contributor

I have implemented support for this in ros-infrastructure/rosdep#521 and tested it with this PR: https://gist.github.com/ipa-mdl/401f74bff9bfe64fd359c4593c4e3797

@dirk-thomas
Copy link
Copy Markdown
Member

What is the status of this PR?

@mathias-luedtke
Copy link
Copy Markdown
Contributor

Works with ros-infrastructure/rosdep#585

@mathias-luedtke
Copy link
Copy Markdown
Contributor

rosdep should now handle this properly.

@dirk-thomas
Copy link
Copy Markdown
Member

@tfoote Cas you please give this another try with the rosdep problem resolved.

@dirk-thomas dirk-thomas requested a review from tfoote June 6, 2018 16:50
Copy link
Copy Markdown
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the new rosdep this appears to be working correctly.

https://gist.github.com/tfoote/e84c8d7c3f34515df9fa75433d34a201

@dirk-thomas dirk-thomas merged commit dd287b7 into ros:master Jun 6, 2018
@jspricke jspricke deleted the fix_curl branch June 6, 2018 22:10
@dirk-thomas
Copy link
Copy Markdown
Member

Could this change be the reason for the following job starting to fail? http://build.ros.org/view/Mdev/job/Mdev__rc_visard__ubuntu_bionic_amd64/4/console

@tfoote
Copy link
Copy Markdown
Member

tfoote commented Jun 7, 2018

Yes, that logic block is going to need to become aware of the virtual package logic as it looks to be implementing it in parallel.
A package from that repo is actually the test case used in https://github.com/ros-infrastructure/rosdep/pull/585/files

@dirk-thomas
Copy link
Copy Markdown
Member

What is the status on this?

@dirk-thomas
Copy link
Copy Markdown
Member

I went ahead and reverted the change in #18223.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants