Fix handling of virtual packages#585
Merged
wjwwood merged 5 commits intoros-infrastructure:masterfrom Mar 21, 2018
mathias-luedtke:fix/virtual-packages
Merged
Fix handling of virtual packages#585wjwwood merged 5 commits intoros-infrastructure:masterfrom mathias-luedtke:fix/virtual-packages
wjwwood merged 5 commits intoros-infrastructure:masterfrom
mathias-luedtke:fix/virtual-packages
Conversation
Contributor
Author
flixr
reviewed
Mar 14, 2018
|
|
||
| results = list(_read_apt_cache_showpkg(['curl', 'wget', '_not_existing', 'libcurl-dev'], exec_fn=m)) | ||
| assert len(results) == 4, results | ||
| pkgs = ['curl', 'wget', '_not_existing', 'libcurl-dev', 'ros-kinetic-rc-genicam-api'] |
Contributor
There was a problem hiding this comment.
will this still work as intended after the next kinetic sync, from which on ros-kinetic-rc-genicam-api will be available?
Contributor
Author
There was a problem hiding this comment.
Yes, this just tests the format parser based on the text file.
gnerator was iterated multiple times
- really read until last line - return as non-virtual without candidate if Reverse Provides is empty
Contributor
Author
wjwwood
approved these changes
Mar 21, 2018
Contributor
wjwwood
left a comment
There was a problem hiding this comment.
lgtm, sorry for the delay in reviewing
Contributor
|
Thanks for working to fix the issue guys. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #521