Skip to content
This repository was archived by the owner on May 31, 2025. It is now read-only.

throw exception instead of accessing invalid memory#971

Merged
dirk-thomas merged 1 commit intokinetic-develfrom
throw_instead_of_segfault
Feb 1, 2017
Merged

throw exception instead of accessing invalid memory#971
dirk-thomas merged 1 commit intokinetic-develfrom
throw_instead_of_segfault

Conversation

@dirk-thomas
Copy link
Copy Markdown
Member

@dirk-thomas dirk-thomas commented Feb 1, 2017

Fixes #969.

@ros/ros_team Please review.

@jspricke
Copy link
Copy Markdown
Member

jspricke commented Feb 1, 2017

+1

@mikaelarguedas
Copy link
Copy Markdown
Member

looks good to me. typo on split in the error message though

@dirk-thomas dirk-thomas force-pushed the throw_instead_of_segfault branch from c9be26b to 4ab11ba Compare February 1, 2017 19:01
@dirk-thomas
Copy link
Copy Markdown
Member Author

Doh, fixed the wrong spelling. Thank you both for the review.

@dirk-thomas dirk-thomas merged commit 6473694 into kinetic-devel Feb 1, 2017
@dirk-thomas dirk-thomas deleted the throw_instead_of_segfault branch February 1, 2017 20:07
rsinnet pushed a commit to MisoRobotics/ros_comm that referenced this pull request Jun 19, 2017
throw exception instead of accessing invalid memory
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants