This repository was archived by the owner on May 31, 2025. It is now read-only.
Merged
Conversation
The file descriptor hard limit was bumped resulting in each ROS node allocating 8GB: https://lists.debian.org/debian-devel/2024/06/msg00041.html
With fixes by Jochen Sprickerhof. Taken from https://salsa.debian.org/science-team/ros-ros-comm/-/blob/b74ca5c2c868a084ab36e46d68f7775518ac4c58/debian/patches/0016-Fixes-for-Python-3.12.patch
this is implicitly pulled-in through the test depends on rosunit, but fails with ros-infrastructure/bloom#649 which disables test dependencies.
Contributor
Author
|
LGTM. Verified desktop_full builds with this change. |
Member
|
Awesome, thanks for your work! |
Contributor
|
I see a new problem that might be connected to this PR: #2389 . |
Member
|
@peci1 I can't reproduce this on Debian (which includes this patches). Can you bisect where it is coming from instead of blaming some PR? |
Contributor
|
Ah, right. I blamed this PR because it was the last one that touched the relevant files, but the error actually started appearing since #2277 (which makes sense, as it only started showing the errors). I've debugged this locally and the culprit was in a few abruptly killed nodes that did not unregister from rosmaster. The Sorry for the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2297 got updated with commits that change the behavior of some packages. I'm opening a new PR set to a few commits back to avoid changing the
ros-o:obese-develbranch@jspricke FYI