Skip to content
This repository was archived by the owner on May 31, 2025. It is now read-only.

Log errors in XmlRpcpp#2277

Merged
sloretz merged 1 commit intoros:noetic-develfrom
Hugal31:feat/log-errors
Apr 25, 2025
Merged

Log errors in XmlRpcpp#2277
sloretz merged 1 commit intoros:noetic-develfrom
Hugal31:feat/log-errors

Conversation

@Hugal31
Copy link
Copy Markdown
Contributor

@Hugal31 Hugal31 commented Sep 13, 2022

Errors were not logged at all. Fix this by using the default log handler with level 0.

Closes #2274

@peci1
Copy link
Copy Markdown
Contributor

peci1 commented Apr 9, 2023

I guess the error logging code could then be simplified by removing the #ifdef for Windows and just relay everything to the normal log handler.

Copy link
Copy Markdown
Contributor

@sloretz sloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

@sloretz sloretz merged commit 5fe0bc4 into ros:noetic-devel Apr 25, 2025
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

xmlrpcpp: Errors are not logged

3 participants