This repository was archived by the owner on May 31, 2025. It is now read-only.
[ROS-O] required patches on current systems#2297
Closed
jspricke wants to merge 5 commits intoros:noetic-develfrom
Closed
[ROS-O] required patches on current systems#2297jspricke wants to merge 5 commits intoros:noetic-develfrom
jspricke wants to merge 5 commits intoros:noetic-develfrom
Conversation
Member
|
This one likely needs another pass with test failures. |
Member
Author
|
I've updated the roslogging patch. This version works for me with Ubuntu 20.04 (ROS Noetic) as well as Debian testing (Python 3.11) |
5022a21 to
75b4aaf
Compare
Member
|
We were having runtime issues with Python 3.11 in our NixOS 23.11 build. I've patched this change on and it seems to be working better. Will report back any new problems we find. |
164a2ac to
a239220
Compare
Contributor
|
It looks like the PR job is failing on this one. Mind looking into it? |
Contributor
|
The only non-critical error is this one: Likely due to 88b9c7f . |
Member
Author
|
Not sure anymore how I verified the version in 2023 but I was able to reproduce the test failure and the new version should fix it. |
sloretz
previously requested changes
May 5, 2025
We just need to protect against symbols starting with double underscores. Having double underscores anywhere else isn't a problem.
Member
Author
|
closing due to #2388 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.