Skip to content
This repository was archived by the owner on May 31, 2025. It is now read-only.

[ROS-O] required patches on current systems#2297

Closed
jspricke wants to merge 5 commits intoros:noetic-develfrom
ros-o:obese-devel
Closed

[ROS-O] required patches on current systems#2297
jspricke wants to merge 5 commits intoros:noetic-develfrom
ros-o:obese-devel

Conversation

@jspricke
Copy link
Copy Markdown
Member

No description provided.

@mjcarroll
Copy link
Copy Markdown
Member

This one likely needs another pass with test failures.

@jspricke
Copy link
Copy Markdown
Member Author

I've updated the roslogging patch. This version works for me with Ubuntu 20.04 (ROS Noetic) as well as Debian testing (Python 3.11)

@mikepurvis
Copy link
Copy Markdown
Member

mikepurvis commented Feb 26, 2024

We were having runtime issues with Python 3.11 in our NixOS 23.11 build. I've patched this change on and it seems to be working better. Will report back any new problems we find.

@jspricke jspricke changed the title rosgraph: update code from Python 3.11 [ROS-O] required patches on current systems Sep 5, 2024
@v4hn v4hn force-pushed the obese-devel branch 2 times, most recently from 164a2ac to a239220 Compare October 14, 2024 11:00
@sloretz
Copy link
Copy Markdown
Contributor

sloretz commented Apr 25, 2025

It looks like the PR job is failing on this one. Mind looking into it?

@v4hn
Copy link
Copy Markdown
Contributor

v4hn commented Apr 28, 2025

The only non-critical error is this one:

Traceback (most recent call last):
  File "/usr/lib/python3.8/unittest/case.py", line 60, in testPartExecutor
    yield
  File "/usr/lib/python3.8/unittest/case.py", line 676, in run
    self._callTestMethod(testMethod)
  File "/usr/lib/python3.8/unittest/case.py", line 633, in _callTestMethod
    method()
  File "/usr/lib/python3/dist-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "/tmp/ws/src/ros_comm/tools/rosgraph/test/test_roslogging.py", line 127, in test_rosconsole__logging_format
    assert_regexp_matches(lout.getvalue().splitlines()[i], log_out)
  File "/usr/lib/python3.8/unittest/case.py", line 1410, in deprecated_func
    return original_func(*args, **kwargs)
  File "/usr/lib/python3.8/unittest/case.py", line 1388, in assertRegex
    raise self.failureException(msg)
AssertionError: Regex didn't match: 'INFO on module [0-9]*\\.[0-9]* [0-9]{4}-[0-9]{2}-[0-9]{2} [0-9]{2}:[0-9]{2}:[0-9]{2}\\.[0-9]{6} [0-9]* rosout /tmp/ws/src/ros_comm/tools/rosgraph/test/test_roslogging\\.py [0-9]* <module> (/unnamed|<unknown_node_name>) [0-9]*\\.[0-9]* [0-9]{4}-[0-9]{2}-[0-9]{2} [0-9]{2}:[0-9]{2}:[0-9]{2}\\.[0-9]{6}' not found in 'INFO on module 1728996043.023153 2024-10-15 04:40:43.023163 139950167390016 rosout /usr/bin/nosetests3 11 <module> /unnamed 1728996043.023189 2024-10-15 04:40:43.023192'

Likely due to 88b9c7f .

@jspricke
Copy link
Copy Markdown
Member Author

Not sure anymore how I verified the version in 2023 but I was able to reproduce the test failure and the new version should fix it.

sloretz
sloretz previously requested changes May 5, 2025
@sloretz sloretz dismissed their stale review May 9, 2025 18:11

changes since review

rhaschke added 3 commits May 10, 2025 10:57
We just need to protect against symbols starting with double underscores.
Having double underscores anywhere else isn't a problem.
@jspricke
Copy link
Copy Markdown
Member Author

closing due to #2388

@jspricke jspricke closed this May 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants