Skip to content
This repository was archived by the owner on May 31, 2025. It is now read-only.

Add add_rostest_gmock function#1303

Merged
dirk-thomas merged 2 commits intoros:lunar-develfrom
pal-robotics-forks:lunar-devel
Feb 2, 2018
Merged

Add add_rostest_gmock function#1303
dirk-thomas merged 2 commits intoros:lunar-develfrom
pal-robotics-forks:lunar-devel

Conversation

@v-lopez
Copy link
Copy Markdown
Contributor

@v-lopez v-lopez commented Jan 11, 2018

This is an extension of the work done here: ros/catkin#897

If/when this is approved, i'll make a pull request for kinetic-devel as well, or feel free to cherry-pick the commit, it shouldn't have any conflicts.

@dirk-thomas
Copy link
Copy Markdown
Member

Can you please update the patch by increasing the minimum version of catkin to 0.7.9 (which is when the new GMock API was introduced.

@v-lopez
Copy link
Copy Markdown
Contributor Author

v-lopez commented Feb 2, 2018

Done

@dirk-thomas
Copy link
Copy Markdown
Member

Thank you for the patch and the quick update.

@dirk-thomas dirk-thomas merged commit e5cdde3 into ros:lunar-devel Feb 2, 2018
dirk-thomas pushed a commit that referenced this pull request Feb 9, 2018
* Add add_rostest_gmock function

* Increase catkin required version due to new GMock API
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants