Skip to content
This repository was archived by the owner on May 31, 2025. It is now read-only.

add support for GMock#897

Merged
dirk-thomas merged 11 commits intokinetic-develfrom
gmock-kinetic-mod
Nov 17, 2017
Merged

add support for GMock#897
dirk-thomas merged 11 commits intokinetic-develfrom
gmock-kinetic-mod

Conversation

@dirk-thomas
Copy link
Copy Markdown
Member

@dirk-thomas dirk-thomas commented Oct 27, 2017

Builds on top of #896 and addresses some issues.

@v-lopez FYI

@v-lopez
Copy link
Copy Markdown
Contributor

v-lopez commented Oct 30, 2017

@dirk-thomas Thanks for the changes, lgtm.

@dirk-thomas
Copy link
Copy Markdown
Member Author

@mikepurvis Would it be possible for you to use this branch for your testing for a little while? That would give us more confidence that it doesn't introduce any regressions...

@mikepurvis
Copy link
Copy Markdown
Member

I've switched our distribution to this branch. FYI @tspicer01

@mikepurvis
Copy link
Copy Markdown
Member

We're not actively using the new gmock support, but I believe none of our unittests have gone up in flames as a result of this change.

@dirk-thomas
Copy link
Copy Markdown
Member Author

@v-lopez Thank you for providing this. I will go ahead and merge this so it will be part of the next release of this package.

@dirk-thomas dirk-thomas merged commit a7f81d0 into kinetic-devel Nov 17, 2017
@dirk-thomas dirk-thomas deleted the gmock-kinetic-mod branch November 17, 2017 03:37
@dirk-thomas
Copy link
Copy Markdown
Member Author

What I didn't realize when review this is that the patch duplicates large blocks of the logic and copy-n-pastes it into the new function catkin_find_gmock_source. In light of this patch failing to build for melodic (which has the googletest 1.8.0) (#910 (comment)) this should not only be fixed but also be cleaned up.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants