This repository was archived by the owner on May 31, 2025. It is now read-only.
Implemented Publisher::isLatched, which until now was dangling.#1
Closed
wjwwood wants to merge 1 commit intoros:masterfrom
wjwwood:master
Closed
Implemented Publisher::isLatched, which until now was dangling.#1wjwwood wants to merge 1 commit intoros:masterfrom wjwwood:master
wjwwood wants to merge 1 commit intoros:masterfrom
wjwwood:master
Conversation
Member
Author
|
Commit has been updated. Still need to run and verify the tests. |
Member
|
Please update the patch to latest master. |
Member
Author
|
Reopened as #27. Could not rebase because I deleted my original fork of it. |
tfoote
pushed a commit
that referenced
this pull request
Jun 17, 2016
contradict
pushed a commit
to contradict/ros_comm
that referenced
this pull request
Aug 12, 2016
rqt_robot_dashboard: initial import from external
contradict
pushed a commit
to contradict/ros_comm
that referenced
this pull request
Aug 12, 2016
Removed unneeded lines to enable merge
Nickolaim
added a commit
to Nickolaim/ros_comm
that referenced
this pull request
Mar 2, 2018
dirk-thomas
pushed a commit
that referenced
this pull request
May 18, 2018
XmlRpcServer: use unsigned int for rlimit
johnsonshih
referenced
this pull request
in johnsonshih/ros_comm
Sep 18, 2018
* Fix roslz4 build issue on Windows * Fix xmlrpcpp build issue on Windows, fix polling fails when run on Windows * Fix roscpp build issue on Windows * Fix rosbag_storage build issue on Windows * fix issues in python scripts to run roscore on Windows * Fix build issue when build with CATKIN_ENABLE_TESTING on but without googletest * Fix build issue on Windows * correct typo * refine changes * refine changes * Adjust what to expose from XmlRpcClientForTest * Add back const * Proper indent * Create helper function for socketpair on Windows * fine tune change * revert unrelated whitespace changes * export _logHandler from XmlRpcLogHandler * Fix message_filters test code build break * refine change * refine change * Add missing header file back * Add storage-class attribute for various classes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented Publisher::isLatched, which until now was dangling.
See: https://code.ros.org/trac/ros/ticket/4038
This is the example which exposes the bug:
https://github.com/wjwwood/ros_comm/zipball/is_latched_bug
The pull request fixes the problem, but I have not added tests, nor have I run the ros_comm tests, yet.
Thanks to Michael Carroll for reporting this.