Switch from TinyXML to TinyXML2#52
Merged
mikaelarguedas merged 1 commit intoros:indigo-develfrom Jul 25, 2017
Merged
Conversation
Member
|
Thanks @rojkov for the contribution. This needs ros-visualization/qt_gui_core#96 to be merged. Looking if any other package is assuming that pluginlib uses tinyxml. |
The library TinyXML is considered to be unmaintained and since all future development is focused on TinyXML2 this patch updates pluginlib to use TinyXML2. Signed-off-by: Dmitry Rozhkov <dmitry.rozhkov@linux.intel.com>
Member
|
ros-visualization/qt_gui_core#96 has been merges, we now need ros-visualization/qt_gui_core#96 and ros-visualization/qt_gui_core#97 to be integrated to the |
mikaelarguedas
added a commit
that referenced
this pull request
Jul 27, 2017
This reverts commit 04af213.
mikaelarguedas
added a commit
that referenced
this pull request
Jul 27, 2017
mikaelarguedas
pushed a commit
that referenced
this pull request
Jul 27, 2017
The library TinyXML is considered to be unmaintained and since all future development is focused on TinyXML2 this patch updates pluginlib to use TinyXML2. Signed-off-by: Dmitry Rozhkov <dmitry.rozhkov@linux.intel.com>
Merged
mikaelarguedas
added a commit
that referenced
this pull request
Jul 27, 2017
* Switch from TinyXML to TinyXML2 (#52) The library TinyXML is considered to be unmaintained and since all future development is focused on TinyXML2 this patch updates pluginlib to use TinyXML2. Signed-off-by: Dmitry Rozhkov <dmitry.rozhkov@linux.intel.com> * add invalid xml exception * throw InvalidXMLException when plugin file is invalid
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The library TinyXML is considered to be unmaintained and
since all future development is focused on TinyXML2 this
patch updates pluginlib to use TinyXML2.