Skip to content
This repository was archived by the owner on May 31, 2025. It is now read-only.

Collection of patches rebased for Kinetic#63

Merged
dirk-thomas merged 11 commits intokinetic-develfrom
patches-eric-wieser
Jul 8, 2016
Merged

Collection of patches rebased for Kinetic#63
dirk-thomas merged 11 commits intokinetic-develfrom
patches-eric-wieser

Conversation

@dirk-thomas
Copy link
Copy Markdown
Member

eric-wieser and others added 11 commits June 24, 2016 16:46
This prevents this function having to be repeated. It can also now be removed from rospy.rostime.
This fixes #50, and makes ros/ros_comm#781 easier to fix
`struct.pack('5s', b'abcde')` works just fine for me on 3.5.0
And so `chr` is also not safe. `b'\0' works fine in both versions.
This way things like `np.float32` and `np.int64` will be accepted as well.
And fix them to return integers not floats for floor division, to match `datetime.timedelta`
@dirk-thomas
Copy link
Copy Markdown
Member Author

@ros/ros_team Please review this carefully.

@eric-wieser
Copy link
Copy Markdown
Contributor

Fantastic, thanks!

@wjwwood
Copy link
Copy Markdown
Member

wjwwood commented Jun 28, 2016

lgtm for kinetic

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants