This repository was archived by the owner on May 31, 2025. It is now read-only.
Use classmethod, not staticmethod#52
Closed
eric-wieser wants to merge 1 commit intoros:indigo-develfrom
Closed
Conversation
This prevents this function having to be repeated. It can also now be removed from rospy.rostime.
eric-wieser
added a commit
to eric-wieser/ros_comm
that referenced
this pull request
Mar 31, 2016
Requires ros/genpy#52 to be merged/released first
Contributor
Author
|
Will this only get merged if rebased on |
Member
|
In general these PRs did not receive much attention since they are mostly refactoring / cleanup with little improvements. Many other tickets are therefore considered to be more important. Especially changing those in Indigo (which has been released over two years ago) doesn't seem necessary. Anyway I have created #63 which combines all the pending PRs from you (except #55, see comment on that ticket) and is against the kinetic-devel branch. |
Member
|
Thank you for the patch. Merged to kinetic-devel in #63. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents this function having to be repeated. It can also now be removed from rospy.rostime.