This repository was archived by the owner on May 31, 2025. It is now read-only.
Add deprecation comment about Pose2D#130
Merged
tfoote merged 1 commit intojade-develfrom Oct 16, 2018
Merged
Conversation
It started as unused and still isn't recommended. Followup to #129
tfoote
added a commit
to ros2/common_interfaces
that referenced
this pull request
Apr 11, 2020
This is a forward port of ros/common_msgs#130 This fixes #93 Signed-off-by: Tully Foote <tfoote@osrfoundation.org>
Member
|
I think I agree with this direction. I see opposing comment at answers.ros.org#q339764 from @SteveMacenski, so I'm just interested in how the conversation would develop. |
Contributor
|
I'm very late, but I disagree with this move. |
Member
|
Agreed |
|
This pull request has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/discussion-standardizing-ros-interfaces/33693/1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It started as unused and still isn't recommended.
Followup to #129