Skip to content
This repository was archived by the owner on May 31, 2025. It is now read-only.

feat(pose2d_stamped): Added Pose2D Stamped message#129

Closed
reinzor wants to merge 1 commit intoros:jade-develfrom
ruvu:feat/pose2d_stamped
Closed

feat(pose2d_stamped): Added Pose2D Stamped message#129
reinzor wants to merge 1 commit intoros:jade-develfrom
ruvu:feat/pose2d_stamped

Conversation

@reinzor
Copy link
Copy Markdown
Contributor

@reinzor reinzor commented Jul 6, 2018

No description provided.

@tfoote
Copy link
Copy Markdown
Member

tfoote commented Jul 6, 2018

Could you please provide some context as to why you'd like to add this message?

@reinzor
Copy link
Copy Markdown
Contributor Author

reinzor commented Jul 7, 2018

For some of our local planners, we would like to expose references or errors. The pose stamped message would suffice however it is all 2d and is is not easy to plot or view the yaw error for example.

@tfoote
Copy link
Copy Markdown
Member

tfoote commented Jul 9, 2018

In general our recommendation is to use a full 3D representation of everything and for 2D specific applications make the appropriate projections into the plane for their calculations but optimally will preserve the 3D information during processing.

If we have parallel copies of 2D datatypes every UI and other pipeline will end up needing to have dual interfaces to plot everything. And you will end up with not being able to use 3D tools for 2D use cases even if they're completely valid, as you'd have to reimplement it with different inputs and outputs. It's not particularly hard to plot the 2D pose or compute the yaw error for the Pose message and there are already tools and libraries that can do this for you.

As an example of where it's powerful, if you have a camera detected goal object. You may want the base planner to navigate to next to the goal, but then you'll want to reach for the goal with your robot's arm. Being able to have all tools process the 3D goal and derivative poses is much simpler if everything operates on the full 3D datatypes.

@tfoote tfoote closed this Jul 9, 2018
@reinzor
Copy link
Copy Markdown
Contributor Author

reinzor commented Jul 11, 2018

Thanks for your elaborate comment. I do agree after reading it; It might be better way then to improve the plot GUI functionalities. Can I ask one last question. Why is the Pose2D (without stamped) present in the geometry_msgs, or is this just legacy?

@tfoote
Copy link
Copy Markdown
Member

tfoote commented Jul 11, 2018

Yeah, it's still there for legacy reasons. Early on we created a bunch of messages on speculation for "completeness". But since then we've learned not to do that. I should add a note in the documentation related to this, it's a not uncommon question.

Here's the initial commit talking about it being "unused"
4b4d790#diff-6c097b109f04f06d9ad03d3eced1b5a9

tfoote added a commit that referenced this pull request Jul 11, 2018
It started as unused and still isn't recommended.

Followup to #129
@tfoote
Copy link
Copy Markdown
Member

tfoote commented Jul 11, 2018

PR in #130 to add a comment in the Pose2D message.

Also contributions for plotting the Pose in GUIs would definitely be appreciated.

tfoote added a commit that referenced this pull request Oct 16, 2018
It started as unused and still isn't recommended.

Followup to #129
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants