Fix #289 enumerate_arrays comments#344
Merged
Merged
Conversation
Member
Author
|
?r @torkleyy |
torkleyy
approved these changes
Nov 22, 2021
torkleyy
left a comment
Member
There was a problem hiding this comment.
I think that's a good fix for the issue - but personally I find the comments too "noisy".
Still seems like an improvement though! 
Member
Author
I agree with that. I just saw the issue and thought it made a nice quick break from uni work.
Thanks! |
torkleyy
pushed a commit
to torkleyy/ron
that referenced
this pull request
Jun 6, 2022
Fix ron-rs#289 enumerate_arrays comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #289 and an associated
TODOby moving the array index comments in front of the items using/*[i]*/.CHANGELOG.md