Skip to content

enumerate_arrays doesn't annotate last item in array and comments are badly placed #289

@Boscop

Description

@Boscop

https://docs.rs/ron/0.6.2/ron/ser/struct.PrettyConfig.html

enumerate_arrays doesn't annotate last item in array:

(
    tags: [
        "asd",// [0]
        "4k",// [1]
        "foo",// [2]
        "bar",// [3]
        "2020",
    ],
    inputs: {
        BufferA: [
            None,// [0]
            None,// [1]
            None,// [2]
            None,
        ],
        Image: [
            Some((
                asset: Misc(Buffer),
                sampler: (filter:mipmap,wrap:clamp,vflip:true),
            )),// [0]
            None,// [1]
            None,// [2]
            Some((
                asset: Misc(Stream),
                sampler: (filter:linear,wrap:clamp,vflip:true),
            )),
        ],
        BufferB: [
            Some((
                asset: Misc(Buffer),
                sampler: (filter:linear,wrap:clamp,vflip:true),
            )),// [0]
            None,// [1]
            None,// [2]
            None,
        ],
        Common: [
            None,// [0]
            None,// [1]
            None,// [2]
            None,
        ],
    },
)

Putting the comment after each item looks weird, especially with large items that span multiple lines.
This part looks very weird:

            Some((
                asset: Misc(Buffer),
                sampler: (filter:mipmap,wrap:clamp,vflip:true),
            )),// [0]
            None,// [1]

Also, it looks weird that there is no space between each item and //.

I suggest putting the comment before each item, so that they are at the same indentation level (thus visually easier to scan), like this:

        Image: [
            // [0]
            Some((
                asset: Misc(Buffer),
                sampler: (filter:mipmap,wrap:clamp,vflip:true),
            )),
            // [1]
            None,
            // [2]
            None,
            // [3]
            Some((
                asset: Misc(Stream),
                sampler: (filter:linear,wrap:clamp,vflip:true),
            )),
        ],

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions