Roll back parameter default tree shaking#4520
Merged
lukastaegert merged 7 commits intomasterfrom Jun 1, 2022
Merged
Conversation
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#roll-back-parameter-default-tree-shakingor load it into the REPL: |
This was referenced Jun 1, 2022
Codecov Report
@@ Coverage Diff @@
## master #4520 +/- ##
==========================================
- Coverage 98.77% 98.76% -0.01%
==========================================
Files 209 209
Lines 7436 7395 -41
Branches 2130 2108 -22
==========================================
- Hits 7345 7304 -41
Misses 32 32
Partials 59 59
Continue to review full report at Codecov.
|
1 task
pos777
pushed a commit
to pos777/rollup
that referenced
this pull request
Jun 18, 2022
* Add more regression tests * Remove call parameter deoptimization * Remove includeWithoutParameterDefaults * Remove default parameter tree-shaking logic * Clean up deoptimizations * Clean up deoptimizations
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
See comments at #4518
Description
Considering the unprecedented amount of small bugs that the parameter default tree-shaking has caused, I decided to roll back the feature indefinitely for now. The problem is that for this feature to work correctly, we need to be 100% sure that for every function, we can either track 100% of the calls or if not, deoptimize it. The latter has turned out to become the literal whack-a-mole, causing me to inject so much special logic into the feature that IMO is in no relation to its value. I kept all the regression tests (quite a few!) created for the feature in case I ever attempt it again after some major changes in the call tracking logic.
Sorry to everyone who was looking forward to this 😔