Deoptimize parameter defaults when referenced from object/array/class literals#4518
Merged
lukastaegert merged 1 commit intomasterfrom May 31, 2022
Merged
Deoptimize parameter defaults when referenced from object/array/class literals#4518lukastaegert merged 1 commit intomasterfrom
lukastaegert merged 1 commit intomasterfrom
Conversation
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#gh-4516_deoptimize_defaultsor load it into the REPL: |
Codecov Report
@@ Coverage Diff @@
## master #4518 +/- ##
==========================================
+ Coverage 98.74% 98.77% +0.02%
==========================================
Files 208 208
Lines 7437 7432 -5
Branches 2124 2130 +6
==========================================
- Hits 7344 7341 -3
+ Misses 34 32 -2
Partials 59 59
Continue to review full report at Codecov.
|
1e11811 to
f09908d
Compare
9 tasks
pos777
pushed a commit
to pos777/rollup
that referenced
this pull request
Jun 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Resolves #4516
Description
This resolves another oversight in the original default parameter implementation. The current solution is to explicitly deoptimize when something is referenced in any kind of literal.