Skip to content

feat: skip barrel files when all imports in the barrel files are marked as side effect free#9155

Draft
IWANABETHATGUY wants to merge 6 commits into04-14-refactor_add_entry_idx_for_entrypointfrom
04-16-fix_8920-2
Draft

feat: skip barrel files when all imports in the barrel files are marked as side effect free#9155
IWANABETHATGUY wants to merge 6 commits into04-14-refactor_add_entry_idx_for_entrypointfrom
04-16-fix_8920-2

Conversation

@IWANABETHATGUY
Copy link
Copy Markdown
Member

@IWANABETHATGUY IWANABETHATGUY commented Apr 19, 2026 •
edited
Loading

Closed #8920

@IWANABETHATGUY IWANABETHATGUY mentioned this pull request Apr 19, 2026
Draft
@IWANABETHATGUY Graphite App
Copy link
Copy Markdown
Member Author

IWANABETHATGUY commented Apr 19, 2026 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@IWANABETHATGUY IWANABETHATGUY mentioned this pull request Apr 19, 2026
Merged
@IWANABETHATGUY IWANABETHATGUY changed the title uu fix: 8920 Apr 19, 2026
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review April 19, 2026 13:49
@IWANABETHATGUY IWANABETHATGUY changed the title fix: 8920 test-perf: 8920 Apr 19, 2026
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 19, 2026

Merging this PR will not alter performance

✅ 4 untouched benchmarks
⏩ 10 skipped benchmarks1

Comparing 04-16-fix_8920-2 (52bdc7e) with main (f554244)2

Open in CodSpeed

Footnotes

  1. 10 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on 04-14-refactor_add_entry_idx_for_entrypoint (fd82afa) during the generation of this report, so main (f554244) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@IWANABETHATGUY IWANABETHATGUY marked this pull request as draft April 19, 2026 13:57
@IWANABETHATGUY IWANABETHATGUY changed the title test-perf: 8920 feat: skip barrel files when all imports in the barrel files are marked as side effect free Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@IWANABETHATGUY IWANABETHATGUY

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@IWANABETHATGUY