Skip to content

refactor: add entry idx for EntryPoint#9100

Draft
IWANABETHATGUY wants to merge 1 commit intomainfrom
04-14-refactor_add_entry_idx_for_entrypoint
Draft

refactor: add entry idx for EntryPoint#9100
IWANABETHATGUY wants to merge 1 commit intomainfrom
04-14-refactor_add_entry_idx_for_entrypoint

Conversation

@IWANABETHATGUY
Copy link
Copy Markdown
Member

@IWANABETHATGUY IWANABETHATGUY commented Apr 14, 2026

No description provided.

@IWANABETHATGUY Graphite App
Copy link
Copy Markdown
Member Author

IWANABETHATGUY commented Apr 14, 2026 •
edited
Loading

How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 14, 2026

✅ Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit c0e4c02
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/69ddeca2d6e58b00082b5266
😎 Deploy Preview https://deploy-preview-9100--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 14, 2026 •
edited
Loading

✅ Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit fd82afa
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/69e0de01dddd700008e79b49
😎 Deploy Preview https://deploy-preview-9100--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@IWANABETHATGUY IWANABETHATGUY force-pushed the 04-14-refactor_add_entry_idx_for_entrypoint branch 4 times, most recently from 6e9915f to 89334dd Compare April 16, 2026 04:38
@IWANABETHATGUY IWANABETHATGUY changed the base branch from main to graphite-base/9100 April 16, 2026 05:04
@IWANABETHATGUY IWANABETHATGUY force-pushed the 04-14-refactor_add_entry_idx_for_entrypoint branch from 89334dd to cf32a71 Compare April 16, 2026 05:04
@IWANABETHATGUY IWANABETHATGUY changed the base branch from graphite-base/9100 to 04-16-refactor_used_symbol_refs April 16, 2026 05:04
@IWANABETHATGUY IWANABETHATGUY mentioned this pull request Apr 16, 2026
Merged
@graphite-app graphite-app Bot changed the base branch from 04-16-refactor_used_symbol_refs to graphite-base/9100 April 16, 2026 05:14
hyf0
hyf0 reviewed Apr 16, 2026
View reviewed changes
Comment thread crates/rolldown/src/module_loader/module_loader.rs
}

let entry_points = entry_points.into_iter().collect_vec();
let mut entry_points: Vec<EntryPoint> = entry_points.into_iter().collect();
Copy link
Copy Markdown
Member

@hyf0 hyf0 Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the issue of using IndexVec<EntryPoint> directly?

Copy link
Copy Markdown
Member Author

@IWANABETHATGUY IWANABETHATGUY Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because some of the entry points may be eliminated in include_statements, which means they are not stable, I store the Idx inside the EntryPoint rather than in IndexVec indices.

Copy link
Copy Markdown
Member

@hyf0 hyf0 Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rolldown/crates/rolldown/src/stages/link_stage/mod.rs

Lines 146 to 149 in c32075e

entry_points.extend(rest);
for (i, entry) in entry_points.iter_mut().enumerate() {
entry.entry_index = EntryIdx::from_raw(i.try_into().expect("Too many entry points"));
}

Will entry_points remove items or only does extention?

@graphite-app graphite-app Bot force-pushed the graphite-base/9100 branch from 4efb8fe to 71ed056 Compare April 16, 2026 05:19
@graphite-app graphite-app Bot force-pushed the 04-14-refactor_add_entry_idx_for_entrypoint branch from cf32a71 to 499ccd2 Compare April 16, 2026 05:19
@graphite-app graphite-app Bot changed the base branch from graphite-base/9100 to main April 16, 2026 05:20
@graphite-app graphite-app Bot force-pushed the 04-14-refactor_add_entry_idx_for_entrypoint branch from 499ccd2 to c32075e Compare April 16, 2026 05:20
@IWANABETHATGUY IWANABETHATGUY force-pushed the 04-14-refactor_add_entry_idx_for_entrypoint branch from c32075e to fd82afa Compare April 16, 2026 13:02
@IWANABETHATGUY IWANABETHATGUY mentioned this pull request Apr 19, 2026
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyf0 hyf0 hyf0 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@IWANABETHATGUY IWANABETHATGUY

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@IWANABETHATGUY @hyf0