chore(js): replace dprint with oxfmt by Boshen · Pull Request #7214 · rolldown/rolldown

Boshen · 2025-11-25T06:49:38Z

update .vscode/settings.json and .vscode/extensions.json

graphite-app · 2025-11-25T06:49:47Z

How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

socket-security · 2025-11-25T06:50:08Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	oxfmt@0.21.0

View full report

netlify · 2025-11-25T06:50:58Z

✅ Deploy Preview for rolldown-rs ready!

Name	Link
🔨 Latest commit	`938617b`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/69527543dcc39a0008547f7a
😎 Deploy Preview	https://deploy-preview-7214--rolldown-rs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

crates/rolldown_testing/src/hmr-runtime.js

tasks/generator/src/output/rust.rs

github-actions · 2025-12-08T13:37:54Z

Benchmarks Rust

target: main(c7c080d)
pr: oxfmt(dba0e22)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     69.2±1.73ms        ? ?/sec    1.04     71.9±2.57ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.01     75.7±2.20ms        ? ?/sec    1.00     75.1±3.80ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    113.9±2.36ms        ? ?/sec    1.01    115.2±2.49ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.03    126.6±2.78ms        ? ?/sec    1.00    123.2±2.85ms        ? ?/sec
bundle/bundle@threejs                                        1.00     42.1±2.33ms        ? ?/sec    1.02     43.1±1.02ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     45.5±1.17ms        ? ?/sec    1.01     45.9±0.99ms        ? ?/sec
bundle/bundle@threejs10x                                     1.03    409.1±7.96ms        ? ?/sec    1.00    396.9±5.54ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.05    479.4±9.50ms        ? ?/sec    1.00    455.7±4.10ms        ? ?/sec
scan/scan@rome_ts                                            1.07     91.0±2.66ms        ? ?/sec    1.00     85.1±2.52ms        ? ?/sec
scan/scan@threejs                                            1.07     30.4±0.56ms        ? ?/sec    1.00     28.4±0.32ms        ? ?/sec
scan/scan@threejs10x                                         1.04    307.9±6.24ms        ? ?/sec    1.00    296.8±4.42ms        ? ?/sec

IWANABETHATGUY · 2025-12-15T15:41:48Z

I noticed that many of the changes are multiple lines collapsed into a single line. Can we preserve the original layout instead?

Copilot

Pull request overview

This PR adds oxfmt as the formatter for JavaScript/TypeScript files, replacing dprint. The changes include updating the Rust code generator to use oxfmt instead of dprint, updating package dependencies, and reformatting all JavaScript, TypeScript, JSON, and Markdown files according to oxfmt's style rules.

Key Changes

Updated the Rust generator to invoke oxfmt with the --stdin-filepath flag
Replaced dprint dependency with oxfmt in package.json
Reformatted all JS/TS/JSON/MD files with oxfmt's formatting rules

Reviewed changes

Copilot reviewed 189 out of 193 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
tasks/generator/src/output/rust.rs	Updated formatter command from dprint to oxfmt
pnpm-lock.yaml	Removed dprint packages, added oxfmt packages
scripts/*/.ts	Reformatted TypeScript files
scripts/*/.json	Reformatted JSON files
scripts/*/.md	Reformatted markdown summary files
packages/rolldown/src/*/.ts	Reformatted TypeScript source files
packages/test-dev-server/*/.ts	Reformatted test server files
packages/test-dev-server/*/.json	Reformatted JSON config files

All changes appear to be automated formatting changes from the new formatter, with no functional code changes beyond the formatter switch in the Rust generator.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

IWANABETHATGUY · 2025-12-16T09:20:07Z

I noticed that many of the changes are multiple lines collapsed into a single line. Can we preserve the original layout instead?

Just a nitpick, looks good to me for other parts. cc @hyf0

hyf0 · 2025-12-25T06:08:01Z

I noticed that many of the changes are multiple lines collapsed into a single line. Can we preserve the original layout instead?

Just a nitpick, looks good to me for other parts. cc @hyf0

Probably it's caused by different printWidth. I'm fine with the new change as long as we're gonna keep this style in the future.

Boshen · 2025-12-29T09:56:44Z

Merge activity

Dec 29, 9:56 AM UTC: The merge label 'graphite: merge-when-ready' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Dec 29, 9:56 AM UTC: This pull request can not be added to the Graphite merge queue. Please try rebasing and resubmitting to merge when ready.
Dec 29, 9:56 AM UTC: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
Dec 29, 9:57 AM UTC: The merge label 'graphite: merge-when-ready' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Dec 29, 12:33 PM UTC: Boshen added this pull request to the Graphite merge queue.
Dec 29, 12:43 PM UTC: Merged by the Graphite merge queue.

Copilot

Pull request overview

Copilot reviewed 189 out of 193 changed files in this pull request and generated no new comments.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 190 out of 194 changed files in this pull request and generated no new comments.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 188 out of 193 changed files in this pull request and generated no new comments.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- [x] update .vscode/settings.json and .vscode/extensions.json

@shulaoda

## [1.0.0-beta.58] - 2025-12-31 ### 💥 BREAKING CHANGES - experimental/devtools: rename InputOptions#debug to InputOptions#devtools (#7686) by @Copilot ### 🚀 Features - implement target feature check in `should_transform_js` for raw options (#7697) by @shulaoda - support `output.dynamicImportInCjs` option (#7677) by @shulaoda - types: expose `ChecksOptions` type (#7653) by @sapphi-red ### 🐛 Bug Fixes - export runtime helpers for cross-chunk access (#7658) by @shulaoda - cjs namespace merging regression (#7665) by @IWANABETHATGUY - replace panic with proper error handling for hash placeholder generation (#7661) by @shulaoda - remove the blank line between shebang and postBanner (#7643) by @btea - rolldown_plugin_vite_reporter: apply padding before ANSI coloring for proper size column alignment (#7649) by @shulaoda ### 🚜 Refactor - rust: use `StableModuleId` as the map key if possible (#7718) by @hyf0 - rust: return `StableModuleId` instead of `&str` from `Module#stable_id()` (#7717) by @hyf0 - rust: return correct stable id of external module from `Module#stable_id()` (#7716) by @hyf0 - rust: introduce `StableModuleId` type (#7715) by @hyf0 - rust: reduce unnecessary `id.as_arc_str().clone().into()` (#7714) by @hyf0 - rust: remove `ModuleId#resource_id` and use `as_arc_str` directly (#7710) by @hyf0 - rust: remove unused `Module#id_clone` (#7709) by @hyf0 - rust: remove `Module#id_as_str` and use `Module#id` directly (#7708) by @hyf0 - consolidate namespace call analysis into import analyzer (#7657) by @IWANABETHATGUY - rust: make `ExternalModule#id` have the type `ModuleId` (#7707) by @hyf0 - rust: rename `Module#id` to `Module#id_as_str` (#7706) by @hyf0 - rust: use `ModuleId` instead of raw `ArcStr` for `ScanStageCache` (#7701) by @hyf0 - simplify error propagation in cache merge (#7702) by @shulaoda - use `ModuleId` as the type of `ResolvedId#id` (#7694) by @hyf0 - types: rename `resolved_request_info.rs` to `resolved_id.rs` and move its contents (#7687) by @hyf0 - devtools: emit data to `<CWD>/node_modules/.rolldown` (#7692) by @hyf0 - use `InvalidOption` for hash placeholder generation errors (#7674) by @shulaoda - rolldown_error: remove dependency on rolldown_utils (#7672) by @shulaoda - use nodejs-built-in-modules v1.0.0 directly in callsites (#7667) by @Boshen ### 📚 Documentation - migrate input options content from options to auto gen docs (#7663) by @mdong1909 - create reference index page (#7659) by @mdong1909 - tweak auto-generated reference output (#7654) by @sapphi-red - initialize auto-gen docs (#7252) by @mdong1909 ### ⚙️ Miscellaneous Tasks - deps: update napi (#7705) by @renovate[bot] - pin Node.js version to 24.12.0 LTS in .node-version file (#7713) by @Copilot - update esbuild test reasons (#7703) by @sapphi-red - deps: update crate-ci/typos action to v1.40.1 (#7696) by @renovate[bot] - deps: update oxc to v0.106.0 (#7512) by @renovate[bot] - js: replace dprint with oxfmt (#7214) by @Boshen - deps: update dependency oxlint to v1.36.0 (#7691) by @renovate[bot] - deps: update github-actions (#7679) by @renovate[bot] - deps: update npm packages (#7680) by @renovate[bot] - deps: update rust crates (#7678) by @renovate[bot] - deps: update oxc resolver to v11.16.2 (#7668) by @renovate[bot] - add API reference files to knip entry points (#7669) by @Copilot - deps: update notify (#7651) by @sapphi-red - add `homepage` field to package.json (#7648) by @trivikr - deps: update oxc resolver to v11.16.1 (#7647) by @renovate[bot] - deps: update rolldown-plugin-dts to 0.20.0 (#7645) by @shulaoda Co-authored-by: shulaoda <165626830+shulaoda@users.noreply.github.com>

github-actions bot assigned Boshen Nov 25, 2025

Boshen commented Nov 25, 2025

View reviewed changes

crates/rolldown_testing/src/hmr-runtime.js Show resolved Hide resolved

Boshen force-pushed the oxfmt branch from ca04f5e to dc7d5b1 Compare December 8, 2025 13:21

Boshen commented Dec 8, 2025

View reviewed changes

tasks/generator/src/output/rust.rs Outdated Show resolved Hide resolved

Boshen force-pushed the oxfmt branch from dc7d5b1 to dba0e22 Compare December 15, 2025 15:28

Boshen marked this pull request as ready for review December 15, 2025 15:29

Copilot AI review requested due to automatic review settings December 15, 2025 15:29

Boshen assigned IWANABETHATGUY and hyf0 and unassigned Boshen Dec 15, 2025

Boshen changed the title ~~chore(js): add oxfmt~~ chore(js): replace dprint with oxfmt Dec 15, 2025

Copilot started reviewing on behalf of Boshen December 15, 2025 16:10 View session

Copilot AI reviewed Dec 15, 2025

View reviewed changes

Boshen force-pushed the oxfmt branch from dba0e22 to 3f8c729 Compare December 29, 2025 09:56

Boshen added the graphite: merge-when-ready label Dec 29, 2025

Copilot AI review requested due to automatic review settings December 29, 2025 10:20

Boshen force-pushed the oxfmt branch from 3f8c729 to 993f374 Compare December 29, 2025 10:20

Copilot started reviewing on behalf of Boshen December 29, 2025 10:20 View session

Copilot AI reviewed Dec 29, 2025

View reviewed changes

Boshen force-pushed the oxfmt branch from 215832c to a79a1bc Compare December 29, 2025 10:31

Copilot AI review requested due to automatic review settings December 29, 2025 10:31

Copilot started reviewing on behalf of Boshen December 29, 2025 10:32 View session

Copilot AI reviewed Dec 29, 2025

View reviewed changes

Copilot AI review requested due to automatic review settings December 29, 2025 11:30

Boshen force-pushed the oxfmt branch from b9b7ff3 to c7ad0eb Compare December 29, 2025 11:30

Copilot started reviewing on behalf of Boshen December 29, 2025 11:31 View session

Boshen force-pushed the oxfmt branch from c720dec to 2791c08 Compare December 29, 2025 11:33

Copilot AI reviewed Dec 29, 2025

View reviewed changes

IWANABETHATGUY approved these changes Dec 29, 2025

View reviewed changes

chore(js): replace dprint with oxfmt (#7214)

938617b

- [x] update .vscode/settings.json and .vscode/extensions.json

graphite-app bot force-pushed the oxfmt branch from 2829161 to 938617b Compare December 29, 2025 12:34

graphite-app bot merged commit 938617b into main Dec 29, 2025
36 checks passed

graphite-app bot deleted the oxfmt branch December 29, 2025 12:43

graphite-app bot removed the graphite: merge-when-ready label Dec 29, 2025

IWANABETHATGUY pushed a commit that referenced this pull request Dec 30, 2025

chore(js): replace dprint with oxfmt (#7214)

0e717d2

- [x] update .vscode/settings.json and .vscode/extensions.json

This was referenced Dec 31, 2025

release: v1.0.0-beta.58 #7719

Closed

release: v1.0.0-beta.58 #7721

Merged

Conversation

Boshen commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

graphite-app bot commented Nov 25, 2025

How to use the Graphite Merge Queue

Uh oh!

socket-security bot commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs ready!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Rust

Uh oh!

IWANABETHATGUY commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Key Changes

Reviewed changes

Uh oh!

IWANABETHATGUY commented Dec 16, 2025

Uh oh!

hyf0 commented Dec 25, 2025

Uh oh!

Boshen commented Dec 29, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Boshen commented Nov 25, 2025 •

edited

Loading

socket-security bot commented Nov 25, 2025 •

edited

Loading

netlify bot commented Nov 25, 2025 •

edited

Loading

github-actions bot commented Dec 8, 2025 •

edited

Loading

IWANABETHATGUY commented Dec 15, 2025 •

edited

Loading

Boshen commented Dec 29, 2025 •

edited by graphite-app bot

Loading