Skip to content

fix(plugin/vite-resolve): resolve glob side effects field correctly#5079

Merged
hyf0 merged 1 commit intomainfrom
fix/plugin-vite-resolve-resolve-side-effects-with-glob-correctly
Jun 26, 2025
Merged

fix(plugin/vite-resolve): resolve glob side effects field correctly#5079
hyf0 merged 1 commit intomainfrom
fix/plugin-vite-resolve-resolve-side-effects-with-glob-correctly

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Jun 26, 2025

pkgJson.check_side_effects_for should receive a relative path.

refs vitejs/rolldown-vite#283

@netlify
Copy link

netlify bot commented Jun 26, 2025

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 4506347
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/685d0f9f9b4f19000828e85b

@github-actions
Copy link
Contributor

github-actions bot commented Jun 26, 2025

Benchmarks Rust

  • target: main(276d4ac)
  • pr: fix/plugin-vite-resolve-resolve-side-effects-with-glob-correctly(4506347)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.02     76.8±2.38ms        ? ?/sec    1.00     75.3±1.86ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.03     88.4±2.28ms        ? ?/sec    1.00     86.0±1.69ms        ? ?/sec
bundle/bundle@rome_ts                                        1.04    117.1±2.50ms        ? ?/sec    1.00    112.4±1.76ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.03    135.7±1.90ms        ? ?/sec    1.00    131.3±1.58ms        ? ?/sec
bundle/bundle@threejs                                        1.01     41.7±2.56ms        ? ?/sec    1.00     41.1±1.31ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.04     52.3±2.34ms        ? ?/sec    1.00     50.3±0.60ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    435.9±4.74ms        ? ?/sec    1.00    435.2±6.60ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    507.7±4.67ms        ? ?/sec    1.00    505.9±4.05ms        ? ?/sec
scan/scan@rome_ts                                            1.00     87.0±1.38ms        ? ?/sec    1.01     87.9±2.44ms        ? ?/sec
scan/scan@threejs                                            1.00     30.6±0.82ms        ? ?/sec    1.01     30.8±1.77ms        ? ?/sec
scan/scan@threejs10x                                         1.00    317.7±5.38ms        ? ?/sec    1.00    318.0±4.11ms        ? ?/sec

@hyf0 hyf0 added this pull request to the merge queue Jun 26, 2025
Merged via the queue into main with commit 0d9038a Jun 26, 2025
24 checks passed
@hyf0 hyf0 deleted the fix/plugin-vite-resolve-resolve-side-effects-with-glob-correctly branch June 26, 2025 09:38
@github-actions github-actions bot mentioned this pull request Jun 27, 2025
Merged
hyf0 pushed a commit that referenced this pull request Jun 27, 2025
@github-actions @sapphi-red
release: v1.0.0-beta.21 (#5084)
c747854 
## [1.0.0-beta.21] - 2025-06-27

### 🚀 Features

- rolldown: oxc_resolver v11.3.0 (#5078) by @Boshen
- debug: support to emit `meta.json` (#5075) by @hyf0
- plugin/vite-resolve: support tsconfig paths (#5004) by @sapphi-red

### 🐛 Bug Fixes

- plugin/vite-resolve: resolve glob side effects field correctly (#5079)
by @sapphi-red
- rolldown_plugin_transform: don't load tsconfig for files in
node_modules (#5074) by @sapphi-red
- preserveModules: correctly generate absolute chunk file names (#5072)
by @shulaoda
- vite-tests: fix `pnpm install` failure (#5070) by @shulaoda

### 📚 Documentation

- contrib-guide: add memory profile steps (#5053) by @sapphi-red

### ⚙️ Miscellaneous Tasks

- remove `just lint` in `packages/debug/package.json` (#5080) by @hyf0
- deps: update dependency rolldown-plugin-dts to v0.13.12 (#5077) by
@renovate[bot]
- repo: make `pnpm lint-knip` part of `just lint-node` (#5076) by @hyf0
- infra: move `insta.yaml` to the workspace root (#5073) by @shulaoda

Co-authored-by: sapphi-red <49056869+sapphi-red@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyf0 hyf0 hyf0 approved these changes

@shulaoda shulaoda shulaoda approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sapphi-red @hyf0 @shulaoda