Skip to content

fix(preserveModules): correctly generate absolute chunk file names#5072

Merged
shulaoda merged 1 commit intomainfrom
06-26-fix_preservemodules_correctly_generate_absolute_chunk_file_names
Jun 26, 2025
Merged

fix(preserveModules): correctly generate absolute chunk file names#5072
shulaoda merged 1 commit intomainfrom
06-26-fix_preservemodules_correctly_generate_absolute_chunk_file_names

Conversation

@shulaoda
Copy link
Member

@shulaoda shulaoda commented Jun 25, 2025 •
edited
Loading

closes #5067

@shulaoda Graphite App
Copy link
Member Author

shulaoda commented Jun 25, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Jun 25, 2025

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 5506753
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/685c6e3e0425d60008b062c8

@shulaoda shulaoda requested a review from IWANABETHATGUY June 25, 2025 21:47
@shulaoda shulaoda marked this pull request as ready for review June 25, 2025 21:47
@github-actions
Copy link
Contributor

github-actions bot commented Jun 25, 2025

Benchmarks Rust

  • target: main(63a053d)
  • pr: 06-26-fix_preservemodules_correctly_generate_absolute_chunk_file_names(5506753)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     76.8±1.96ms        ? ?/sec    1.01     77.7±2.29ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     88.2±2.17ms        ? ?/sec    1.00     88.5±2.25ms        ? ?/sec
bundle/bundle@rome_ts                                        1.01    114.8±2.90ms        ? ?/sec    1.00    114.1±1.91ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    134.6±2.21ms        ? ?/sec    1.00    134.8±1.91ms        ? ?/sec
bundle/bundle@threejs                                        1.00     42.1±2.46ms        ? ?/sec    1.00     42.0±2.47ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     51.2±2.14ms        ? ?/sec    1.00     51.2±0.96ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    439.6±5.68ms        ? ?/sec    1.01    442.3±4.06ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    514.6±3.96ms        ? ?/sec    1.01    517.4±7.32ms        ? ?/sec
scan/scan@rome_ts                                            1.00     88.5±1.42ms        ? ?/sec    1.01     89.5±1.67ms        ? ?/sec
scan/scan@threejs                                            1.00     30.8±0.32ms        ? ?/sec    1.03     31.9±0.81ms        ? ?/sec
scan/scan@threejs10x                                         1.00    323.3±4.25ms        ? ?/sec    1.01    326.0±4.59ms        ? ?/sec

@shulaoda shulaoda added this pull request to the merge queue Jun 26, 2025
Merged via the queue into main with commit daf88f9 Jun 26, 2025
25 checks passed
@shulaoda shulaoda deleted the 06-26-fix_preservemodules_correctly_generate_absolute_chunk_file_names branch June 26, 2025 04:18
@github-actions github-actions bot mentioned this pull request Jun 27, 2025
Merged
hyf0 pushed a commit that referenced this pull request Jun 27, 2025
@github-actions @sapphi-red
release: v1.0.0-beta.21 (#5084)
c747854 
## [1.0.0-beta.21] - 2025-06-27

### 🚀 Features

- rolldown: oxc_resolver v11.3.0 (#5078) by @Boshen
- debug: support to emit `meta.json` (#5075) by @hyf0
- plugin/vite-resolve: support tsconfig paths (#5004) by @sapphi-red

### 🐛 Bug Fixes

- plugin/vite-resolve: resolve glob side effects field correctly (#5079)
by @sapphi-red
- rolldown_plugin_transform: don't load tsconfig for files in
node_modules (#5074) by @sapphi-red
- preserveModules: correctly generate absolute chunk file names (#5072)
by @shulaoda
- vite-tests: fix `pnpm install` failure (#5070) by @shulaoda

### 📚 Documentation

- contrib-guide: add memory profile steps (#5053) by @sapphi-red

### ⚙️ Miscellaneous Tasks

- remove `just lint` in `packages/debug/package.json` (#5080) by @hyf0
- deps: update dependency rolldown-plugin-dts to v0.13.12 (#5077) by
@renovate[bot]
- repo: make `pnpm lint-knip` part of `just lint-node` (#5076) by @hyf0
- infra: move `insta.yaml` to the workspace root (#5073) by @shulaoda

Co-authored-by: sapphi-red <49056869+sapphi-red@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IWANABETHATGUY IWANABETHATGUY IWANABETHATGUY approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Unexpected file conversion

2 participants

@shulaoda @IWANABETHATGUY