Skip to content

chore(publish/pkg.pr.new): print correct version#3128

Merged
hyf0 merged 2 commits into
mainfrom
12-12-chore_publish_pkg.pr.new_print_correct_version
Dec 12, 2024
Merged

chore(publish/pkg.pr.new): print correct version#3128
hyf0 merged 2 commits into
mainfrom
12-12-chore_publish_pkg.pr.new_print_correct_version

Conversation

@hyf0

@hyf0 hyf0 commented Dec 11, 2024

Copy link
Copy Markdown
Member

Description

@hyf0 hyf0 marked this pull request as ready for review December 11, 2024 19:40
@hyf0 hyf0 mentioned this pull request Dec 11, 2024
Merged
@hyf0 Graphite App

hyf0 commented Dec 11, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions

github-actions Bot commented Dec 11, 2024

Copy link
Copy Markdown
Contributor

Benchmarks Rust

  • target: 12-12-fix_node_print_correct_version_for_nightly(97affe4)
  • pr: 12-12-chore_publish_pkg.pr.new_print_correct_version(da67cf0)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     71.2±1.76ms        ? ?/sec    1.04     73.9±1.02ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00     93.6±1.33ms        ? ?/sec    1.00     94.1±1.23ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00    107.4±0.72ms        ? ?/sec    1.01    108.2±1.23ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     80.5±1.20ms        ? ?/sec    1.01     80.9±1.91ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    123.8±1.54ms        ? ?/sec    1.02    126.7±1.82ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00    206.5±5.66ms        ? ?/sec    1.09    225.7±4.77ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00   262.2±11.08ms        ? ?/sec    1.00    261.1±6.08ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    137.8±2.45ms        ? ?/sec    1.02    140.4±2.08ms        ? ?/sec
bundle/bundle@threejs                                               1.03     37.6±1.22ms        ? ?/sec    1.00     36.6±1.26ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     86.6±1.72ms        ? ?/sec    1.02     88.6±1.50ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00    100.3±1.53ms        ? ?/sec    1.00    100.0±0.46ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     47.2±0.44ms        ? ?/sec    1.00     47.3±0.48ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    400.0±8.61ms        ? ?/sec    1.00    400.6±3.40ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00  1081.0±11.12ms        ? ?/sec    1.00  1076.4±15.32ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00  1296.2±17.11ms        ? ?/sec    1.00  1295.3±10.87ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    474.0±3.84ms        ? ?/sec    1.00    473.1±3.75ms        ? ?/sec
remapping/remapping                                                 1.02     27.7±0.17ms        ? ?/sec    1.00     27.2±0.07ms        ? ?/sec
remapping/render-chunk-remapping                                    1.02     75.2±0.71ms        ? ?/sec    1.00     73.4±0.54ms        ? ?/sec
scan/scan@rome-ts                                                   1.00     96.2±0.77ms        ? ?/sec    1.02     97.9±1.31ms        ? ?/sec
scan/scan@threejs                                                   1.00     28.0±1.08ms        ? ?/sec    1.03     28.7±0.40ms        ? ?/sec
scan/scan@threejs10x                                                1.00    285.4±3.36ms        ? ?/sec    1.01    287.1±2.70ms        ? ?/sec

Base automatically changed from 12-12-fix_node_print_correct_version_for_nightly to main December 12, 2024 02:51
@hyf0 hyf0 added this pull request to the merge queue Dec 12, 2024
Merged via the queue into main with commit 3a47d0e Dec 12, 2024
@hyf0 hyf0 deleted the 12-12-chore_publish_pkg.pr.new_print_correct_version branch December 12, 2024 03:08
@sapphi-red sapphi-red mentioned this pull request May 12, 2026
Merged
graphite-app Bot pushed a commit that referenced this pull request May 12, 2026
@sapphi-red
ci: replace igorskyflyer/action-readfile with cat (#9369)
28bc48f 
Replace this action with `cat` to reduce attack surface.

refs #3128
IWANABETHATGUY pushed a commit that referenced this pull request May 18, 2026
@sapphi-red @IWANABETHATGUY
ci: replace igorskyflyer/action-readfile with cat (#9369)
3eb125b 
Replace this action with `cat` to reduce attack surface.

refs #3128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@underfin underfin underfin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hyf0 @underfin