Skip to content

fix(node): print correct version for nightly/canary#3126

Merged
hyf0 merged 1 commit into
mainfrom
12-12-fix_node_print_correct_version_for_nightly
Dec 12, 2024
Merged

fix(node): print correct version for nightly/canary#3126
hyf0 merged 1 commit into
mainfrom
12-12-fix_node_print_correct_version_for_nightly

Conversation

@hyf0

@hyf0 hyf0 commented Dec 11, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

@hyf0 Graphite App

hyf0 commented Dec 11, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@hyf0 hyf0 marked this pull request as ready for review December 11, 2024 16:06
@netlify

netlify Bot commented Dec 11, 2024 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 97affe4
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/6759e6215b692f00089f6f95

@hyf0 hyf0 force-pushed the 12-12-fix_node_print_correct_version_for_nightly branch from ba5d70b to 686feb5 Compare December 11, 2024 16:17
@hyf0 hyf0 changed the title fix(node): print correct version for nightly fix(node): print correct version for nightly/canary Dec 11, 2024
@hyf0 hyf0 force-pushed the 12-12-fix_node_print_correct_version_for_nightly branch 4 times, most recently from fa9e42b to fa9003b Compare December 11, 2024 16:34
@github-actions

github-actions Bot commented Dec 11, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Benchmarks Rust

  • target: main(ab7b6b4)
  • pr: 12-12-fix_node_print_correct_version_for_nightly(97affe4)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     72.0±1.51ms        ? ?/sec    1.02     73.2±1.72ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.01     96.0±2.28ms        ? ?/sec    1.00     95.1±2.03ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00    109.4±1.91ms        ? ?/sec    1.00    109.7±1.68ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     81.2±1.42ms        ? ?/sec    1.01     81.7±1.76ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    126.0±1.65ms        ? ?/sec    1.00    126.3±1.68ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.01    217.8±5.08ms        ? ?/sec    1.00    216.7±4.10ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00    259.0±6.48ms        ? ?/sec    1.00    258.7±6.25ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    139.3±2.06ms        ? ?/sec    1.01    140.1±2.01ms        ? ?/sec
bundle/bundle@threejs                                               1.00     37.9±0.87ms        ? ?/sec    1.00     37.7±0.62ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.02     91.1±1.88ms        ? ?/sec    1.00     89.7±1.17ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.01    107.0±1.28ms        ? ?/sec    1.00    106.0±1.05ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     48.1±0.55ms        ? ?/sec    1.00     48.1±0.71ms        ? ?/sec
bundle/bundle@threejs10x                                            1.01   410.7±18.42ms        ? ?/sec    1.00    408.4±3.74ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00   1078.1±6.25ms        ? ?/sec    1.00   1080.6±7.00ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00  1292.1±10.10ms        ? ?/sec    1.00   1296.9±8.01ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    477.6±4.92ms        ? ?/sec    1.01    483.3±4.53ms        ? ?/sec
remapping/remapping                                                 1.05     28.2±0.16ms        ? ?/sec    1.00     26.8±0.15ms        ? ?/sec
remapping/render-chunk-remapping                                    1.00     73.8±0.53ms        ? ?/sec    1.00     74.0±0.69ms        ? ?/sec
scan/scan@rome-ts                                                   1.00    100.2±3.15ms        ? ?/sec    1.01    100.9±1.41ms        ? ?/sec
scan/scan@threejs                                                   1.00     28.6±0.45ms        ? ?/sec    1.00     28.7±0.77ms        ? ?/sec
scan/scan@threejs10x                                                1.00    288.6±3.11ms        ? ?/sec    1.00    288.5±3.21ms        ? ?/sec

@hyf0 hyf0 force-pushed the 12-12-fix_node_print_correct_version_for_nightly branch 9 times, most recently from a5809e2 to ac58858 Compare December 11, 2024 19:16
@hyf0 hyf0 force-pushed the 12-12-fix_node_print_correct_version_for_nightly branch from ac58858 to 97affe4 Compare December 11, 2024 19:21
@hyf0 hyf0 mentioned this pull request Dec 11, 2024
Merged
@hyf0 hyf0 added this pull request to the merge queue Dec 12, 2024
Merged via the queue into main with commit 39f9197 Dec 12, 2024
@hyf0 hyf0 deleted the 12-12-fix_node_print_correct_version_for_nightly branch December 12, 2024 02:51
@mrginglymus mrginglymus mentioned this pull request Sep 18, 2025
Closed
Copilot AI mentioned this pull request Sep 18, 2025
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@underfin underfin underfin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

rolldown-cli could not print correct version.

2 participants

@hyf0 @underfin