feat: don't normalize options on js side - part4#2870
Merged
hyf0 merged 1 commit intorolldown:mainfrom Nov 22, 2024
Merged
Conversation
✅ Deploy Preview for rolldown-rs canceled.
|
hyf0
approved these changes
Nov 22, 2024
Member
There was a problem hiding this comment.
I'm uncertain whether we should remove the current NormalizedInputOptions and NormalizedOutputOptions and replace them with InputOptions and OutputOptions
No needed.
NormalizedInputOptions NormalizedOutputOptions will be refactored in #1041. You could leave it to me. Great works!
sxzz
added a commit
to unplugin/unplugin-isolated-decl
that referenced
this pull request
Nov 23, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 30, 2024
### Description Related to #2870 Since we have already implemented `NormalizedInputOptionsImpl`, the following hack behavior is unnecessary. https://github.com/rolldown/rolldown/blob/59f76dc54c9d39e3ad7099c03ffdaa477f4e116e/packages/rolldown/src/options/bindingify-input-options.ts#L30-L35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes #2835
I'm uncertain whether we should remove the current
NormalizedInputOptionsandNormalizedOutputOptionsand replace them withInputOptionsandOutputOptions. If this change is necessary, it would be the final part.