Skip to content

chore: remove unnecessary forced inputOptions#onLog#2989

Merged
hyf0 merged 1 commit intorolldown:mainfrom
shulaoda:chore/remove-unnecessary-input-options-on-log
Nov 30, 2024
Merged

chore: remove unnecessary forced inputOptions#onLog#2989
hyf0 merged 1 commit intorolldown:mainfrom
shulaoda:chore/remove-unnecessary-input-options-on-log

Conversation

@shulaoda
Copy link
Copy Markdown
Member

Description

Related to #2870

Since we have already implemented NormalizedInputOptionsImpl, the following hack behavior is unnecessary.

// Force `inputOptions.onLog` to `logHandler` because some rollup plugin hook tests use `options.onLog`.
const onLog = (inputOptions.onLog = getLogger(
getObjectPlugins(rawPlugins),
getOnLog(inputOptions, logLevel),
logLevel,
))

@shulaoda shulaoda changed the title chore: remove unnecessary forced inputOptions.onLog chore: remove unnecessary forced inputOptions#onLog Nov 30, 2024
@netlify
Copy link
Copy Markdown

netlify bot commented Nov 30, 2024

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 757c4b4
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/674a61af20f2a800087b43fc

Copy link
Copy Markdown
Member

@hyf0 hyf0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hyf0 hyf0 added this pull request to the merge queue Nov 30, 2024
Merged via the queue into rolldown:main with commit ae332e7 Nov 30, 2024
@shulaoda shulaoda deleted the chore/remove-unnecessary-input-options-on-log branch November 30, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants