Skip to content

feat(node/rolldown): support OutputOptions#advancedChunks#2167

Merged
hyf0 merged 4 commits intomainfrom
09-05-feat_node_rolldown_support_outputoptions_advancedchunks_
Sep 5, 2024
Merged

feat(node/rolldown): support OutputOptions#advancedChunks#2167
hyf0 merged 4 commits intomainfrom
09-05-feat_node_rolldown_support_outputoptions_advancedchunks_

Conversation

@hyf0
Copy link
Member

@hyf0 hyf0 commented Sep 5, 2024

Description

@hyf0 hyf0 marked this pull request as ready for review September 5, 2024 06:12
@hyf0 Graphite App
Copy link
Member Author

hyf0 commented Sep 5, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hyf0 and the rest of your teammates on Graphite Graphite

@hyf0 hyf0 force-pushed the 09-05-feat_node_rolldown_support_outputoptions_advancedchunks_ branch from 46493d2 to 2d88ab9 Compare September 5, 2024 06:16
@hyf0 hyf0 requested a review from IWANABETHATGUY September 5, 2024 06:18
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024

Benchmarks Rust

  • target: 09-04-feat_rust_advance-chunks_should_include_matched_module_s_dependencies_too(48635c9)
  • pr: 09-05-feat_node_rolldown_support_outputoptions_advancedchunks_(2d88ab9)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     52.5±0.77ms        ? ?/sec    1.01     52.8±0.81ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00     75.5±1.17ms        ? ?/sec    1.00     75.7±0.84ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00     93.0±2.32ms        ? ?/sec    1.00     93.2±1.03ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     61.0±0.69ms        ? ?/sec    1.00     60.9±0.73ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    101.7±0.85ms        ? ?/sec    1.01    102.5±0.93ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.02    182.1±4.62ms        ? ?/sec    1.00    178.8±1.27ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00    225.2±2.76ms        ? ?/sec    1.00    224.9±4.04ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    117.9±1.14ms        ? ?/sec    1.00    118.2±1.00ms        ? ?/sec
bundle/bundle@threejs                                               1.00     33.2±1.10ms        ? ?/sec    1.00     33.1±1.13ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     79.4±0.93ms        ? ?/sec    1.01     80.0±0.39ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.02    100.4±0.78ms        ? ?/sec    1.00     98.3±2.31ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.01     42.6±0.42ms        ? ?/sec    1.00     42.1±0.28ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    361.6±3.48ms        ? ?/sec    1.00    360.2±2.79ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.02   993.2±11.18ms        ? ?/sec    1.00    978.4±6.37ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00  1243.0±12.72ms        ? ?/sec    1.00  1245.2±12.65ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.01    431.7±2.92ms        ? ?/sec    1.00    428.5±2.87ms        ? ?/sec
remapping/remapping                                                 1.00     32.9±0.29ms        ? ?/sec    1.01     33.3±0.19ms        ? ?/sec
remapping/render-chunk-remapping                                    1.00     82.4±0.46ms        ? ?/sec    1.02     84.1±0.66ms        ? ?/sec
scan/scan@rome-ts                                                   1.00     81.8±1.12ms        ? ?/sec    1.00     81.7±0.63ms        ? ?/sec
scan/scan@threejs                                                   1.00     25.3±0.19ms        ? ?/sec    1.00     25.3±0.17ms        ? ?/sec
scan/scan@threejs10x                                                1.00    257.4±1.71ms        ? ?/sec    1.00    257.3±1.44ms        ? ?/sec

@hyf0 hyf0 force-pushed the 09-04-feat_rust_advance-chunks_should_include_matched_module_s_dependencies_too branch from 48635c9 to 8402e8e Compare September 5, 2024 07:14
Base automatically changed from 09-04-feat_rust_advance-chunks_should_include_matched_module_s_dependencies_too to main September 5, 2024 07:54
@hyf0 hyf0 added this pull request to the merge queue Sep 5, 2024
Merged via the queue into main with commit 851475d Sep 5, 2024
@hyf0 hyf0 deleted the 09-05-feat_node_rolldown_support_outputoptions_advancedchunks_ branch September 5, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IWANABETHATGUY IWANABETHATGUY IWANABETHATGUY approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hyf0 @IWANABETHATGUY