Skip to content

refactor(rust/code-splitting): pre compute module's dependencies#2160

Merged
hyf0 merged 2 commits intomainfrom
09-04-refactor_rust_code-splitting_pre_compute_module_s_dependencies
Sep 5, 2024
Merged

refactor(rust/code-splitting): pre compute module's dependencies#2160
hyf0 merged 2 commits intomainfrom
09-04-refactor_rust_code-splitting_pre_compute_module_s_dependencies

Conversation

@hyf0
Copy link
Member

@hyf0 hyf0 commented Sep 4, 2024 •
edited
Loading

Description

advancedChunks need to use the same dependencies that code splitting used. Instead of doing the same computation again, we just reuse it.

@hyf0 Graphite App
Copy link
Member Author

hyf0 commented Sep 4, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hyf0 and the rest of your teammates on Graphite Graphite

@hyf0 hyf0 changed the title refactor(rust/code-splitting): pre compute module\'s dependencies refactor(rust/code-splitting): pre compute module's dependencies Sep 4, 2024
@hyf0 hyf0 marked this pull request as ready for review September 4, 2024 14:45
This was referenced Sep 4, 2024
Merged
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024

Benchmarks Rust

  • target: 09-04-feat_rust_advance-chunks_a_module_could_be_catched_by_multiple_match_groups(6dca879)
  • pr: 09-04-refactor_rust_code-splitting_pre_compute_module_s_dependencies(1bf664c)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     53.9±1.12ms        ? ?/sec    1.04     56.3±3.30ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00     76.7±1.88ms        ? ?/sec    1.02     78.2±2.24ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00     93.3±1.45ms        ? ?/sec    1.08    101.1±3.10ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.01     63.6±1.64ms        ? ?/sec    1.00     63.0±1.28ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    102.5±1.10ms        ? ?/sec    1.02    105.0±1.11ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.13   208.8±13.52ms        ? ?/sec    1.00    184.9±4.82ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.08    242.8±7.56ms        ? ?/sec    1.00    225.4±3.33ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    119.1±1.76ms        ? ?/sec    1.00    119.0±1.50ms        ? ?/sec
bundle/bundle@threejs                                               1.00     33.5±1.24ms        ? ?/sec    1.06     35.4±2.22ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     79.5±1.54ms        ? ?/sec    1.02     81.3±3.07ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00     99.6±3.83ms        ? ?/sec    1.02    101.5±2.57ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     42.9±0.77ms        ? ?/sec    1.00     43.0±0.28ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    359.8±3.28ms        ? ?/sec    1.05    376.9±7.62ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00   987.2±10.96ms        ? ?/sec    1.02  1007.3±12.19ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.02  1273.7±22.57ms        ? ?/sec    1.00  1253.6±25.65ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    430.9±3.93ms        ? ?/sec    1.03    444.1±4.11ms        ? ?/sec
remapping/remapping                                                 1.00     33.7±0.51ms        ? ?/sec    1.00     33.6±1.07ms        ? ?/sec
remapping/render-chunk-remapping                                    1.00     85.9±0.64ms        ? ?/sec    1.00     85.9±0.69ms        ? ?/sec
scan/scan@rome-ts                                                   1.00     81.3±0.85ms        ? ?/sec    1.02     82.8±1.43ms        ? ?/sec
scan/scan@threejs                                                   1.00     25.5±0.18ms        ? ?/sec    1.05     26.7±0.35ms        ? ?/sec
scan/scan@threejs10x                                                1.00    256.8±1.32ms        ? ?/sec    1.05    269.2±2.44ms        ? ?/sec

@hyf0 hyf0 mentioned this pull request Sep 5, 2024
Merged
@hyf0 hyf0 self-assigned this Sep 5, 2024
Base automatically changed from 09-04-feat_rust_advance-chunks_a_module_could_be_catched_by_multiple_match_groups to main September 5, 2024 06:51
@hyf0 hyf0 added this pull request to the merge queue Sep 5, 2024
Merged via the queue into main with commit f003965 Sep 5, 2024
@hyf0 hyf0 deleted the 09-04-refactor_rust_code-splitting_pre_compute_module_s_dependencies branch September 5, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@hyf0 hyf0

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@hyf0