Skip to content

fix: ensure referenced symbols by entry point chunk got deconflicted#2094

Merged
IWANABETHATGUY merged 2 commits intomainfrom
08-31-fix_ensure_referenced_symbols_by_entry_point_chunk_got_deconflicted
Aug 31, 2024
Merged

fix: ensure referenced symbols by entry point chunk got deconflicted#2094
IWANABETHATGUY merged 2 commits intomainfrom
08-31-fix_ensure_referenced_symbols_by_entry_point_chunk_got_deconflicted

Conversation

@hyf0
Copy link
Copy Markdown
Member

@hyf0 hyf0 commented Aug 30, 2024 •
edited
Loading

Description

This is yet another problem caused by forgetting sync symbols with other parts of bundler. I'm planing to refactor these logic, to make symbols work automatically to prevent problems caused by forgetting.

@hyf0 Graphite App
Copy link
Copy Markdown
Member Author

hyf0 commented Aug 30, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hyf0 and the rest of your teammates on Graphite Graphite

@netlify
Copy link
Copy Markdown

netlify bot commented Aug 30, 2024 •
edited
Loading

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 4db9489
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/66d2cb397f3c5f000831e6f4

@hyf0 hyf0 marked this pull request as ready for review August 30, 2024 20:11
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 30, 2024 •
edited
Loading

Benchmarks Rust

  • target: main(8b7734e)
  • pr: 08-31-fix_ensure_referenced_symbols_by_entry_point_chunk_got_deconflicted(4db9489)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     53.3±0.99ms        ? ?/sec    1.01     53.5±0.73ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00     76.3±1.11ms        ? ?/sec    1.00     76.3±1.38ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00     93.1±1.46ms        ? ?/sec    1.01     94.1±1.99ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.02     62.4±1.62ms        ? ?/sec    1.00     61.3±1.21ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    100.5±0.99ms        ? ?/sec    1.01    101.4±1.25ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00    182.0±2.58ms        ? ?/sec    1.05    190.6±6.70ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00    225.2±2.30ms        ? ?/sec    1.02    229.7±5.91ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    116.3±1.09ms        ? ?/sec    1.00    116.5±0.90ms        ? ?/sec
bundle/bundle@threejs                                               1.00     36.3±0.52ms        ? ?/sec    1.00     36.5±0.91ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     82.1±2.07ms        ? ?/sec    1.01     82.7±1.90ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00     99.2±1.79ms        ? ?/sec    1.04    102.9±2.01ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     45.2±0.40ms        ? ?/sec    1.02     45.9±0.45ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    383.4±2.11ms        ? ?/sec    1.02    390.2±2.93ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00   982.8±11.01ms        ? ?/sec    1.00   981.8±10.19ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00   1236.6±9.49ms        ? ?/sec    1.01  1246.1±12.16ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    451.2±6.68ms        ? ?/sec    1.00    452.2±3.31ms        ? ?/sec
remapping/remapping                                                 1.08     33.3±0.25ms        ? ?/sec    1.00     30.8±0.20ms        ? ?/sec
remapping/render-chunk-remapping                                    1.01     83.8±0.53ms        ? ?/sec    1.00     83.2±0.51ms        ? ?/sec
scan/scan@rome-ts                                                   1.00     82.1±0.80ms        ? ?/sec    1.00     81.8±0.91ms        ? ?/sec
scan/scan@threejs                                                   1.02     29.7±1.18ms        ? ?/sec    1.00     29.1±0.81ms        ? ?/sec
scan/scan@threejs10x                                                1.00    289.1±2.24ms        ? ?/sec    1.00    288.6±2.77ms        ? ?/sec

@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Aug 31, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 31, 2024
@IWANABETHATGUY IWANABETHATGUY force-pushed the 08-31-fix_ensure_referenced_symbols_by_entry_point_chunk_got_deconflicted branch from 109565c to 5015e02 Compare August 31, 2024 07:30
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Aug 31, 2024
Merged via the queue into main with commit dc98faa Aug 31, 2024
@IWANABETHATGUY IWANABETHATGUY deleted the 08-31-fix_ensure_referenced_symbols_by_entry_point_chunk_got_deconflicted branch August 31, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IWANABETHATGUY IWANABETHATGUY IWANABETHATGUY approved these changes

Assignees

No one assigned

Labels

needs-triage

Projects

None yet

Milestone

No milestone

2 participants

@hyf0 @IWANABETHATGUY