Closed
Conversation
✅ Deploy Preview for rolldown-rs canceled.
|
Contributor
Benchmarks Rust |
IWANABETHATGUY
commented
Aug 30, 2024
| .map(|(exported_name, export_ref)| { | ||
| let canonical_ref = link_output.symbols.par_canonical_ref_for(export_ref); | ||
| let symbol = link_output.symbols.get(canonical_ref); | ||
| let canonical_name = &chunk.canonical_names[&canonical_ref]; |
Member
Author
There was a problem hiding this comment.
should use ns_alias.namesapce_alias_ref when the related symbol has namespace_alias
IWANABETHATGUY
commented
Aug 30, 2024
| let canonical_name; | ||
| if let Some(ns_alias) = &symbol.namespace_alias { | ||
| let canonical_ns_name = &chunk.canonical_names[&ns_alias.namespace_ref]; | ||
| canonical_name = if export_default_count == 0 { |
Member
Author
There was a problem hiding this comment.
if you directly use canonical_name = chunk.canonical_names[&ns_alias.namespace_ref].clone();,
we use issue/2085 as a example, the a~1 would be
## a~1.mjs
```js
import { import_b } from "./a.mjs";
var import_b = import_b._default;
export { import_b as default };
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 31, 2024
…2094) <!-- Thank you for contributing! --> ### Description - Fixes #1722 - Fixes #2085 - Closes #2087 This is yet another problem caused by forgetting sync symbols with other parts of bundler. I'm planing to refactor these logic, to make symbols work automatically to prevent problems caused by forgetting. <!-- Please insert your description here and provide especially info about the "what" this PR is solving --> --------- Co-authored-by: IWANABETHATGUY <iwanabethatguy@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
render_chunk_exports#2085