Skip to content

Factorize Moon phases periodic terms#85

Merged
rhannequin merged 1 commit intomainfrom
factorize-moon-phases-periodic-terms
May 31, 2024
Merged

Factorize Moon phases periodic terms#85
rhannequin merged 1 commit intomainfrom
factorize-moon-phases-periodic-terms

Conversation

@rhannequin
Copy link
Owner

This moves periodic terms into their own class. This lets having Astronoby::MoonPhases stay short and clear, instead of being full of dozens of magic numbers.

@rhannequin rhannequin self-assigned this May 27, 2024
@rhannequin rhannequin force-pushed the factorize-moon-phases-periodic-terms branch from e731eb0 to c7f4f53 Compare May 27, 2024 19:38
@rhannequin rhannequin force-pushed the rationalize-negative-angles branch from 3c22580 to 94db55c Compare May 30, 2024 08:52
@rhannequin rhannequin force-pushed the factorize-moon-phases-periodic-terms branch from c7f4f53 to d3166ab Compare May 30, 2024 08:52
@rhannequin rhannequin force-pushed the rationalize-negative-angles branch from 94db55c to 8465d38 Compare May 31, 2024 08:26
@rhannequin rhannequin force-pushed the factorize-moon-phases-periodic-terms branch from d3166ab to c29347d Compare May 31, 2024 08:27
@rhannequin rhannequin force-pushed the rationalize-negative-angles branch from 8465d38 to 998ffc5 Compare May 31, 2024 23:32
Base automatically changed from rationalize-negative-angles to main May 31, 2024 23:35
This moves periodic terms into their own class. This lets having
`Astronoby::MoonPhases` stay short and clear, instead of being full of
dozens of magic numbers.
@rhannequin rhannequin force-pushed the factorize-moon-phases-periodic-terms branch from c29347d to 2de743f Compare May 31, 2024 23:35
@rhannequin rhannequin merged commit d26f1ef into main May 31, 2024
@rhannequin rhannequin deleted the factorize-moon-phases-periodic-terms branch May 31, 2024 23:40
rhannequin added a commit that referenced this pull request Jun 11, 2024
 ## 0.5.0 - 2024-06-11

_If you are upgrading: please see [UPGRADING.md]._

[UPGRADING.md]: https://github.com/rhannequin/astronoby/blob/main/UPGRADING.md

 ### Features

* Make `Sun#mean_anomaly` public ([#72])
* Moon ecliptic coordinates ([#73])
* Moon apparent geocentric equatorial coordinates ([#75])
* Moon horizontal coordinates ([#76])
* Assume Moon's equatorial coordinates are geocentric ([#77])
* Use observer object for geocentric parallax ([#79])
* Moon's phase angle and illuminated fraction ([#80])
* Monthly Moon phases ([#82])
* Rationalize negative degree angles ([#83])
* Factorize Moon phases periodic terms ([#85])
* Introduce observation events for Moon ([#86])

[#72]: #72
[#73]: #73
[#75]: #75
[#76]: #76
[#77]: #77
[#79]: #79
[#80]: #80
[#82]: #82
[#83]: #83
[#85]: #85
[#86]: #86

 ### Improvements

* Create FUNDING.yml ([#70])
* Bump standard from 1.35.1 to 1.36.0 ([#71])
* Bump rexml from 3.2.6 to 3.2.8 ([#74])
* Expand the number of tested Ruby versions ([#84])
* Add Ruby 3.1.6 and 3.3.2 coverage ([#88])
* Improve and update documentation ([#87])
* Update UPGRADING.md ([#89])

[#70]: #70
[#71]: #71
[#74]: #74
[#84]: #84
[#88]: #88
[#87]: #87
[#89]: #89

 ### Backward-incompatible changes

* Use Observer in Horizontal coordinates ([#69])
* Introduce `Astronoby::Distance` value object ([#78])

[#69]: #69
[#78]: #78

**Full Changelog**: v0.4.0...v0.5.0
rhannequin added a commit that referenced this pull request Jun 11, 2024
### Features

* Make `Sun#mean_anomaly` public ([#72])
* Moon ecliptic coordinates ([#73])
* Moon apparent geocentric equatorial coordinates ([#75])
* Moon horizontal coordinates ([#76])
* Assume Moon's equatorial coordinates are geocentric ([#77])
* Use observer object for geocentric parallax ([#79])
* Moon's phase angle and illuminated fraction ([#80])
* Monthly Moon phases ([#82])
* Rationalize negative degree angles ([#83])
* Factorize Moon phases periodic terms ([#85])
* Introduce observation events for Moon ([#86])

[#72]: #72
[#73]: #73
[#75]: #75
[#76]: #76
[#77]: #77
[#79]: #79
[#80]: #80
[#82]: #82
[#83]: #83
[#85]: #85
[#86]: #86

### Improvements

* Create FUNDING.yml ([#70])
* Bump standard from 1.35.1 to 1.36.0 ([#71])
* Bump rexml from 3.2.6 to 3.2.8 ([#74])
* Expand the number of tested Ruby versions ([#84])
* Add Ruby 3.1.6 and 3.3.2 coverage ([#88])
* Improve and update documentation ([#87])
* Update UPGRADING.md ([#89])

[#70]: #70
[#71]: #71
[#74]: #74
[#84]: #84
[#88]: #88
[#87]: #87
[#89]: #89

### Backward-incompatible changes

* Use Observer in Horizontal coordinates ([#69])
* Introduce `Astronoby::Distance` value object ([#78])

[#69]: #69
[#78]: #78

**Full Changelog**: v0.4.0...v0.5.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant