Underscore usage tests - type assertions#2
Conversation
|
Huh, I didn't actually even have to request you as a reviewer on this one @jgonggrijp. GitHub added you automatically, and from what I can tell it did so because you are the "code owner of 1 file in this pull request." I guess I can't guarantee that I won't end up automatically requesting you as a reviewer if you remain a contributor to my repository; let me know if you'd like me to remove you at end of this set as a result.
|
… section of the file and updating the chain tests header.
There was a problem hiding this comment.
Looks all reasonable to me, just some questions and minor remarks.
Huh, I didn't actually even have to request you as a reviewer on this one @jgonggrijp. GitHub added you automatically, and from what I can tell it did so because you are the "code owner of 1 file in this pull request." I guess I can't guarantee that I won't end up automatically requesting you as a reviewer if you remain a contributor to my repository; let me know if you'd like me to remove you at end of this set as a result.
I'm not too worried about it; I expect it will only "auto-request" me when you actually create a PR on your own fork, which I suspect you're not going to do as a regular habit. Furthermore, since it should only do this with files I "co-own", it shouldn't happen with types that are completely irrelevant to me.
Also, I'm watching your fork so I'm getting notifications anyway.
Co-authored-by: Julian Gonggrijp <dev@juliangonggrijp.com>
This reverts commit 49c0a79.
…rray Tests - Usage Tests Cleanup by @reubenrybnik * Underscore usage tests - addition, removal, and labeling of tests (#1) * Removing the EnumerableKey type alias because DT linting is not good at dealing with it between different versions of TypeScript. (cherry picked from commit abe1df7) * Adding comments that describe and anchor tests, changing a few tests slightly, and removing some tests. * Adding some chain tests. * Fixing spelling error. Co-authored-by: Julian Gonggrijp <dev@juliangonggrijp.com> * Updating the mixin test to properly augment Underscore types. * Removing an unnecessary generic type specification. * Wrapping a comment. * Referencing DefinitelyTyped#33479 in more places. Co-authored-by: Julian Gonggrijp <dev@juliangonggrijp.com> * Underscore usage tests - type assertions (#2) * Adding type assertions to usage tests. * Minor updates to the bind test. * Removing comments for chain tests that are already in the chain tests section of the file and updating the chain tests header. * Breaking a function into multiple lines for better readability. * Adding a separate toArray test that infers a more interesting type than any[]. * Replacing a movie reference with a more generic example. * Make indentation more consistent. Co-authored-by: Julian Gonggrijp <dev@juliangonggrijp.com> * Revert "Replacing a movie reference with a more generic example." This reverts commit 49c0a79. Co-authored-by: Julian Gonggrijp <dev@juliangonggrijp.com> * Underscore usage tests - reorganization (#3) * Removing the combinatorial tests label for types. * Making to the types section of tests. * Making updates to the collections section of tests. * Making updates to the arrays section of tests. * Making updates to the functions section of tests. * Making updates to the objects section of tests. * Making updates to the utility section of tests. * Making updates to the OOP section of tests and adding an OOP header to UnderscoreStatic. * Making updates to the chaining section of tests. * Adding a missing word to a sentence. Co-authored-by: Julian Gonggrijp <dev@juliangonggrijp.com> * Changing "sorting" to "order" when describing sortedIndex Co-authored-by: Julian Gonggrijp <dev@juliangonggrijp.com> * Switching "values its keys" to "vice versa" Co-authored-by: Julian Gonggrijp <dev@juliangonggrijp.com> * Removing an inaccurate "no-op" from a description Co-authored-by: Julian Gonggrijp <dev@juliangonggrijp.com> * Splitting up comments between calling mixin and augmenting type definitions Co-authored-by: Julian Gonggrijp <dev@juliangonggrijp.com> * Removing an extra memoize header. * Changing "TSC" to "TypeScript." Co-authored-by: Julian Gonggrijp <dev@juliangonggrijp.com> Co-authored-by: Julian Gonggrijp <dev@juliangonggrijp.com>
This is the second of three PRs discussed in DefinitelyTyped#47543. It adds type assertions to tests and replaces a few generic example values with declared constants.