Underscore usage tests - addition, removal, and labeling of tests#1
Merged
reubenrybnik merged 8 commits intounderscore-tests-usage-tests-cleanupfrom Sep 18, 2020
Conversation
…at dealing with it between different versions of TypeScript. (cherry picked from commit abe1df7)
…slightly, and removing some tests.
8 tasks
jgonggrijp
reviewed
Sep 17, 2020
Collaborator
jgonggrijp
left a comment
There was a problem hiding this comment.
Looks good to me, only minor comments. 👍
Co-authored-by: Julian Gonggrijp <dev@juliangonggrijp.com>
Owner
Author
|
I'm not sure why CI checks are failing; having c86cacd pass but its subsequent commit 36b2384 which just fixes a spelling error in a comment fail is particularly odd. Since linting passes locally and the failure doesn't appear to be related to Underscore I'm going to ignore it and assume that tests will behave again back in DefinitelyTyped#47543. |
jgonggrijp
approved these changes
Sep 18, 2020
Owner
Author
|
Thanks for looking over this @jgonggrijp, only two more PRs in the last PR to go! |
reubenrybnik
added a commit
that referenced
this pull request
Sep 25, 2020
…rray Tests - Usage Tests Cleanup by @reubenrybnik * Underscore usage tests - addition, removal, and labeling of tests (#1) * Removing the EnumerableKey type alias because DT linting is not good at dealing with it between different versions of TypeScript. (cherry picked from commit abe1df7) * Adding comments that describe and anchor tests, changing a few tests slightly, and removing some tests. * Adding some chain tests. * Fixing spelling error. Co-authored-by: Julian Gonggrijp <dev@juliangonggrijp.com> * Updating the mixin test to properly augment Underscore types. * Removing an unnecessary generic type specification. * Wrapping a comment. * Referencing DefinitelyTyped#33479 in more places. Co-authored-by: Julian Gonggrijp <dev@juliangonggrijp.com> * Underscore usage tests - type assertions (#2) * Adding type assertions to usage tests. * Minor updates to the bind test. * Removing comments for chain tests that are already in the chain tests section of the file and updating the chain tests header. * Breaking a function into multiple lines for better readability. * Adding a separate toArray test that infers a more interesting type than any[]. * Replacing a movie reference with a more generic example. * Make indentation more consistent. Co-authored-by: Julian Gonggrijp <dev@juliangonggrijp.com> * Revert "Replacing a movie reference with a more generic example." This reverts commit 49c0a79. Co-authored-by: Julian Gonggrijp <dev@juliangonggrijp.com> * Underscore usage tests - reorganization (#3) * Removing the combinatorial tests label for types. * Making to the types section of tests. * Making updates to the collections section of tests. * Making updates to the arrays section of tests. * Making updates to the functions section of tests. * Making updates to the objects section of tests. * Making updates to the utility section of tests. * Making updates to the OOP section of tests and adding an OOP header to UnderscoreStatic. * Making updates to the chaining section of tests. * Adding a missing word to a sentence. Co-authored-by: Julian Gonggrijp <dev@juliangonggrijp.com> * Changing "sorting" to "order" when describing sortedIndex Co-authored-by: Julian Gonggrijp <dev@juliangonggrijp.com> * Switching "values its keys" to "vice versa" Co-authored-by: Julian Gonggrijp <dev@juliangonggrijp.com> * Removing an inaccurate "no-op" from a description Co-authored-by: Julian Gonggrijp <dev@juliangonggrijp.com> * Splitting up comments between calling mixin and augmenting type definitions Co-authored-by: Julian Gonggrijp <dev@juliangonggrijp.com> * Removing an extra memoize header. * Changing "TSC" to "TypeScript." Co-authored-by: Julian Gonggrijp <dev@juliangonggrijp.com> Co-authored-by: Julian Gonggrijp <dev@juliangonggrijp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first of three PRs discussed in DefinitelyTyped#47543. It includes the following changes:
EnumerableKeyin favor of just usingstring | numberto work around linting issues caused by changes to tests