Enhancements for custom python SPECL, small GENER fixes #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing initial state variable table, and fill with default values. Addresses Issue #96 where the IWAT-STATE1 table did not exist in the UCI.
…minates warning message about inefficiency
…or use in advection, correcting a potential problem with initial non-zero outflows
specl functions defined and initial testing successful
Constrained JupyterLab version and removed optional plugins, due to JupyterLab updates starting causing errors. Clarified installation instructions to better separate the two installation options, which are mutually exclusive.
The time series for inorganic species of nutrients was being assigned an incorrect key in the timeseries dictionary returned by the utlities.get_stimeseries function. The timeseries were not coded with an underscore between the TMEMN and TMEMSB definition as expected by the RQUAL module (https://github.com/respec/HSPsquared/blob/f9555f2e48cc3409f33c29d3c6504d9bdc0f91fb/HSP2/RQUAL_Class.py#L439-L449).
This Python 3.9 environment is basically the same I used for demos and testing in Jan. 2022.
incorrect timeseries key assignment for inorganic nutrient species
test passing the TS and modifying the last step value
Fix pip install bug when jupyter lab version restricted to 3.0.*
Devstate from @rburghol
• Fix to Celsius conversion precision in PSTEMP • AGWO precision in PWATER • GWVS cut off in PWATER • Atmos Dep not getting added to totals in NUTRX and PLANK • PKIF inflow in get_timeseries
Collaborator
|
@PaulDudaRESPEC & @rburghol, this looks like quite an important Pull Request! How many of these issues were resolved with this PR?
Is it time for a v0.11 release? |
Member
Author
|
Hi @aufdenkampe , yes, there's a lot of good stuff in here. I plan to do more testing this week and hopefully by the end of the week I can make an updated release -- as well as tic off some of those issues -- stay tuned! |
rburghol
pushed a commit
to HARPgroup/HSPsquared
that referenced
this pull request
Mar 5, 2025
Enhancements for custom python SPECL, small GENER fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.