incorrect timeseries key assignment for inorganic nutrient species #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The time series for inorganic species of nutrients was being assigned an incorrect key in the timeseries dictionary returned by the utlities.get_stimeseries function. The timeseries were not coded with an underscore between the TMEMN and TMEMSB definition as expected by the RQUAL module (https://github.com/respec/HSPsquared/blob/f9555f2e48cc3409f33c29d3c6504d9bdc0f91fb/HSP2/RQUAL_Class.py#L439-L449).
Collaborator
|
@PaulDudaRESPEC, let us know if you would like to review and/or test this fix. If not, we're happy to merge it directly into the |
Member
|
I gave it a quick review, it looks good. |
PaulDudaRESPEC
added a commit
that referenced
this pull request
Mar 12, 2025
incorrect timeseries key assignment for inorganic nutrient species
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@PaulDudaRESPEC @aufdenkampe @bcous
This is fix for a bug that @bcous discovered when trying to run HSP2 for some project work. He noticed that the timeseries he specified for inorganic nutrient species were not being correctly input into RQUAL and NUTRX modules.
We determined the timeseries for inorganic species of nutrients were being assigned an incorrect key in the timeseries dictionary returned by the utlities.get_stimeseries function. The timeseries were not coded with an underscore between the TMEMN and TMEMSB definitions (i.e. NUIF11 instead of NUIF1_1) as expected by the this section of RQUAL module
HSPsquared/HSP2/RQUAL_Class.py
Lines 439 to 449 in f9555f2