Skip to content

Introduce new ImageFormat component#7083

Merged
jleibs merged 25 commits intomainfrom
jleibs/image_format
Aug 7, 2024
Merged

Introduce new ImageFormat component#7083
jleibs merged 25 commits intomainfrom
jleibs/image_format

Conversation

@jleibs
Copy link
Copy Markdown
Contributor

@jleibs jleibs commented Aug 6, 2024

What

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 6, 2024

Deployed docs

Commit Link
3c172a5 https://landing-cvnwlw1nw-rerun.vercel.app/docs

@jleibs jleibs force-pushed the jleibs/image_format branch 2 times, most recently from 1ef2d25 to 682042e Compare August 6, 2024 23:55
@jleibs jleibs force-pushed the jleibs/image_format branch from afa8b5a to 9cc8583 Compare August 7, 2024 12:19
Copy link
Copy Markdown
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Rust-side of things feel pretty good now imho

/// See also [`Self::from_color_model_and_tensor`].
pub fn from_pixel_format(
resolution: impl Into<Resolution2D>,
[width, height]: [u32; 2],
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should maybe do impl Into<[u32; 2]> here and below

@jleibs jleibs added the 🔩 data model Sorbet label Aug 7, 2024
@jleibs jleibs added 🍏 primitives Relating to Rerun primitives include in changelog labels Aug 7, 2024
@jleibs jleibs changed the title Refactor schema for image_format Introduce new ImageFormat component Aug 7, 2024
@jleibs jleibs marked this pull request as ready for review August 7, 2024 14:39
@jleibs jleibs added the 🪵 Log & send APIs Affects the user-facing API for all languages label Aug 7, 2024
@jleibs jleibs merged commit 4d3afcb into main Aug 7, 2024
@jleibs jleibs deleted the jleibs/image_format branch August 7, 2024 16:51
jleibs added a commit that referenced this pull request Aug 7, 2024
### What
* Closes #7086
* Should maybe wait for #7083

I need someone with Python skills to finish this.

Note that these are revived things:

*
https://ref.rerun.io/docs/python/0.17.0/common/enums/#rerun.ImageFormat
* https://ref.rerun.io/docs/python/0.17.0/common/image_helpers/

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/7096?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/7096?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!
* [x] If have noted any breaking changes to the log API in
`CHANGELOG.md` and the migration guide

- [PR Build Summary](https://build.rerun.io/pr/7096)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.

---------

Co-authored-by: Jeremy Leibs <jeremy@rerun.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🔩 data model Sorbet include in changelog 🪵 Log & send APIs Affects the user-facing API for all languages 🍏 primitives Relating to Rerun primitives

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Combine many Image components into one struct ImageFormat

2 participants