Skip to content

Add back rr.ImageEncoded for backwards compatibility#7096

Merged
jleibs merged 5 commits intomainfrom
emilk/image_encoded.py
Aug 7, 2024
Merged

Add back rr.ImageEncoded for backwards compatibility#7096
jleibs merged 5 commits intomainfrom
emilk/image_encoded.py

Conversation

@emilk
Copy link
Copy Markdown
Member

@emilk emilk commented Aug 7, 2024 •
edited by github-actions bot
Loading

What

I need someone with Python skills to finish this.

Note that these are revived things:

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@emilk emilk added sdk-python Python logging API exclude from changelog PRs with this won't show up in CHANGELOG.md labels Aug 7, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 7, 2024 •
edited
Loading

Deployed docs

Commit Link
35375ed https://landing-8sneny5ja-rerun.vercel.app/docs

emilk
emilk commented Aug 7, 2024
View reviewed changes
rerun_py/rerun_sdk/rerun/_image_encoded.py
ImageFormat.YUY2 = YUY2


def ImageEncoded(
Copy link
Copy Markdown
Member Author

@emilk emilk Aug 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ImageEncoded used to be a class, but is now a function so that it can return either an Image or an EncodedImage. Maybe a Python guru has a better idea?

rerun_py/rerun_sdk/rerun/_image_encoded.py

"""

warnings.warn(
Copy link
Copy Markdown
Member Author

@emilk emilk Aug 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This warning makes the unit tests fail. I have no idea how to fix that.

@jleibs jleibs marked this pull request as ready for review August 7, 2024 18:45
@jleibs jleibs force-pushed the emilk/image_encoded.py branch from 9a8282a to 35375ed Compare August 7, 2024 18:46
@jleibs jleibs merged commit 47d5331 into main Aug 7, 2024
@jleibs jleibs deleted the emilk/image_encoded.py branch August 7, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

exclude from changelog PRs with this won't show up in CHANGELOG.md sdk-python Python logging API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add back old rr.ImageEncoded helper to guide users

2 participants

@emilk @jleibs