Spawn via $PATH 3: C and C++ implementations#3998
Merged
Conversation
This was referenced Oct 25, 2023
ec8de22 to
b9dd5c8
Compare
f62eec4 to
f506eee
Compare
b9dd5c8 to
c9f9336
Compare
c714df8 to
3f41c3b
Compare
4 tasks
Wumpf
requested changes
Oct 26, 2023
Member
Wumpf
left a comment
There was a problem hiding this comment.
almost good to go. Exited to get this in!
| ] } | ||
|
|
||
| cpp-build-all = { depends_on = [ | ||
| "cpp-prepare", |
Member
There was a problem hiding this comment.
isn't that in already implicitly via the other build actions?
Contributor
Author
There was a problem hiding this comment.
$ just cpp-clean && just cpp-build-all
rm -rf build CMakeCache.txt CMakeFiles
pixi run cpp-build-all
Error: /home/cmc/dev/rerun-io/rerun/build is not a directory
error: Recipe `cpp-build-all` failed on line 39 with exit code 1
crates/rerun_c/src/rerun.h
Outdated
| /// spawn_opts: | ||
| /// Configuration of the spawned process. | ||
| /// Refer to `rr_spawn_options` documentation for details. | ||
| /// Passing null is valid and will result in sane defaults. |
Member
There was a problem hiding this comment.
"sane default" could mean anything though ;)
Contributor
Author
There was a problem hiding this comment.
It won't crash and burn is my main point
Contributor
Author
There was a problem hiding this comment.
Turned it into "recommended defaults" ✨
teh-cmc
added a commit
that referenced
this pull request
Oct 26, 2023
Introduces standalone `rerun::spawn(SpawnOptions)` API that allows one to start a Rerun Viewer process ready to listen for TCP connections, as well as the associated `RecordingStream` integration. https://github.com/rerun-io/rerun/assets/2910679/24eb5647-38c1-4049-b249-dc6e00e4ff54 --- Spawn via `$PATH` series: - #3996 - #3997 - #3998
c9f9336 to
db012ec
Compare
teh-cmc
added a commit
that referenced
this pull request
Oct 26, 2023
…mples (#3997) - Get rid of the old thread-based `spawn` functionality. - Redesign `RerunArgs` to get rid of the awful callback while still dealing with Tokio's TLS shenanigans. - Update all tests and examples. The new `RerunArgs` combined with the new `spawn` from PATH now make for a pretty nice experience: ```rust let args = Args::parse(); let (rec, _serve_guard) = args.rerun.init("my_app")?; // do stuff with rec ``` --- Spawn via `$PATH` series: - #3996 - #3997 - #3998 --- - Fixes #2109
3f41c3b to
6704c9f
Compare
Wumpf
approved these changes
Oct 26, 2023
ee2c98f to
a49e28e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rr_spawn(rr_spawn_options)C API that allows one to start a Rerun Viewer process ready to listen for TCP connections, as well as the associatedrr_recording_streamintegration.rerun::spawn()C++ API that allows one to start a Rerun Viewer process ready to listen for TCP connections, as well as the associatedRecordingStreamintegration.23-10-25_12.03.39.patched.mp4
Spawn via
$PATHseries:$PATH1: Rust implementation #3996$PATH2: Redesignclapintegration and clean up all examples #3997$PATH3: C and C++ implementations #3998spawn-like functionality to C++ and Rust #3757Checklist