Merged
Conversation
emilk
reviewed
Sep 25, 2023
| println!("cargo:rustc-env={name}={value}"); | ||
| if should_output_cargo_build_instructions() { | ||
| println!("cargo:rustc-env={name}={value}"); | ||
| } |
Member
There was a problem hiding this comment.
when is set_env used? maybe this should fallback to std::env::set ?
Contributor
Author
There was a problem hiding this comment.
It's used by re_build_tools::export_env_vars().
I think having it fall back is potentially more confusing since it many situations I don't think std::env::set will actually do what the user wants?
3 tasks
teh-cmc
added a commit
that referenced
this pull request
Sep 26, 2023
#3460 removed committed hashes, but `re_types_builder` is still subscribed to changes to `source_hash.txt`. Even though the build script will early exit as soon as it realizes that the hash is `None`, this is enough to invalidate `rustc`'s cache, which then invalidates every crate downstream. `main`:  this branch:  Fixes: - The roundtrip test suite execution time regression - #3266 ### What ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3474) (if applicable) - [PR Build Summary](https://build.rerun.io/pr/3474) - [Docs preview](https://rerun.io/preview/ea449009416498c258c9672706dc3ebc362f16e2/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/ea449009416498c258c9672706dc3ebc362f16e2/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://ref.rerun.io/dev/bench/) - [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
source_hash.txtes from git #3334Main changes:
source_hash.txtfrom git and adds it to gitignore.build.rsunlesssource_hash.txtis presentcargo codegenproduce thesource_hash.txtConfirmed that we catch it when codegen would produce changes: https://github.com/rerun-io/rerun/actions/runs/6302436017/job/17109617144?pr=3461
Checklist