Skip to content

Fix re_types_builder falsely triggering rebuilds #3474

Merged
teh-cmc merged 1 commit intomainfrom
cmc/codegen_shenanigans
Sep 26, 2023
Merged

Fix re_types_builder falsely triggering rebuilds #3474
teh-cmc merged 1 commit intomainfrom
cmc/codegen_shenanigans

Conversation

@teh-cmc
Copy link
Copy Markdown
Contributor

@teh-cmc teh-cmc commented Sep 26, 2023 •
edited
Loading

#3460 removed committed hashes, but re_types_builder is still subscribed to changes to source_hash.txt.

Even though the build script will early exit as soon as it realizes that the hash is None, this is enough to invalidate rustc's cache, which then invalidates every crate downstream.

main:
image

this branch:
image

Fixes:

What

Checklist

@teh-cmc teh-cmc added the do-not-merge Do not merge this PR label Sep 26, 2023
@teh-cmc
Copy link
Copy Markdown
Contributor Author

teh-cmc commented Sep 26, 2023

Reverting #3460 does what we'd expect:
image

@teh-cmc teh-cmc force-pushed the cmc/codegen_shenanigans branch from ea44900 to bd4eb7d Compare September 26, 2023 10:08
@teh-cmc teh-cmc changed the title NOMERGE: ci tests Fix re_types_builder falsely triggering rebuilds Sep 26, 2023
@teh-cmc teh-cmc added ⏱ build-times compilation times 🦟 regression A thing that used to work in an earlier release codegen/idl exclude from changelog PRs with this won't show up in CHANGELOG.md and removed do-not-merge Do not merge this PR labels Sep 26, 2023
@teh-cmc teh-cmc mentioned this pull request Sep 26, 2023
Closed
@teh-cmc teh-cmc marked this pull request as ready for review September 26, 2023 10:12
@teh-cmc teh-cmc linked an issue Sep 26, 2023 that may be closed by this pull request
Fix unnecessary rebuilds by updating to maturin 1.3.1 #3266
Closed
@teh-cmc teh-cmc merged commit dbeaebb into main Sep 26, 2023
@teh-cmc teh-cmc deleted the cmc/codegen_shenanigans branch September 26, 2023 11:32
@olgabot olgabot mentioned this pull request Oct 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jleibs jleibs jleibs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

⏱ build-times compilation times codegen/idl exclude from changelog PRs with this won't show up in CHANGELOG.md 🦟 regression A thing that used to work in an earlier release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix unnecessary rebuilds by updating to maturin 1.3.1

2 participants

@teh-cmc @jleibs