Merged
Conversation
3 tasks
teh-cmc
approved these changes
Sep 19, 2023
Contributor
teh-cmc
left a comment
There was a problem hiding this comment.
LGTM overall but man I really hope we can do this with actual variables and "types" rather than full runtime dictionaries, or this surely won't end well for us... 😬
7bed6b7 to
900c9a7
Compare
900c9a7 to
8c9c4f4
Compare
Wumpf
added a commit
that referenced
this pull request
Sep 19, 2023
…Box2D (#3351) ### What * Fixes #2787 * Fixes #2789 * Fixes #2786 * once #3348 is in ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3351) (if applicable) - [PR Build Summary](https://build.rerun.io/pr/3351) - [Docs preview](https://rerun.io/preview/a655edeb1a52100c77b9a5e6432b8eaaeab083f7/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/a655edeb1a52100c77b9a5e6432b8eaaeab083f7/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://ref.rerun.io/dev/bench/) - [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Make it nice to create from min and (full) sizes.
TODO: How can we generate/write api doc for this?
Rect2D+Box3Dmigration to archetypes #2786Checklist