Fill in remaining C++ samples and tests that were blocked by lack of Box2D#3351
Merged
Fill in remaining C++ samples and tests that were blocked by lack of Box2D#3351
Conversation
ca78334 to
b8f4d7e
Compare
teh-cmc
approved these changes
Sep 19, 2023
Comment on lines
+25
to
+29
| // TODO(andreas): This constant initialization does not work for unknown reasons! | ||
| // On clang(-mac) this set the Rotation3D::IDENTITY to all zero instead of | ||
| // the expected quaternion. | ||
| // Using the same code as a non-constant works fine. | ||
| // const Rotation3DExt Rotation3DExt::IDENTITY = Quaternion::IDENTITY; |
Member
Author
There was a problem hiding this comment.
I poked it for quite a while but couldn't figure it out, so I gave up for now :(
Member
Author
There was a problem hiding this comment.
Rotation is a union type to I reviewed that again, but can't see what's wrong with it
b8f4d7e to
7f10907
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Linestrip{2|3}Dmigration to archetypes #2787Point{2|3}Dmigration to archetypes #2789Rect2D+Box3Dmigration to archetypes #2786Checklist