Revert #2378, causing noninteractive 2D and 3D spaceviews#2395
Closed
Revert #2378, causing noninteractive 2D and 3D spaceviews#2395
Conversation
…)" This reverts commit bdae196.
jleibs
pushed a commit
that referenced
this pull request
Jun 12, 2023
Turns out `store_one_component` is more than a datastore helper... it actually updates a whole bunch of secondary/derived datastructures at the same time. At some point we should really start moving towards a reactive model where secondary indices merely subscribe to the changelog of a single source of truth and react appropriately. Supersedes #2395
Contributor
|
Closing in favor of: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This reverts commit bdae196.
PR #2378 caused all 2D and 3D spaceviews to become non-interactive, meaning you could not zoom or pan.
Checklist
PR Build Summary: https://build.rerun.io/pr/2395
Docs preview: https://rerun.io/preview/6c6f215/docs
Examples preview: https://rerun.io/preview/6c6f215/examples