Fix blueprint sync by bringing back store_one_component#2396
Merged
Conversation
emilk
reviewed
Jun 12, 2023
Member
emilk
left a comment
There was a problem hiding this comment.
Without having looked at this yet: Should the insert_component footgun have a warning in its docstring, or be renamed or removed?
Contributor
Author
I'd argue the footgun is actually But in any case you're right that that's an issue for later, I'll add a comment to not remove |
jleibs
approved these changes
Jun 12, 2023
Contributor
jleibs
left a comment
There was a problem hiding this comment.
There's clearly some discussion to be had here on naming, but approving/merging to unbreak main.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out
store_one_componentis more than a datastore helper... it actually updates a whole bunch of secondary/derived datastructures at the same time.At some point we should really start moving towards a reactive model where secondary indices merely subscribe to the changelog of a single source of truth and react appropriately.
Supersedes #2395