WIP: albedo textures as color maps + integration into depth clouds#1487
Closed
WIP: albedo textures as color maps + integration into depth clouds#1487
Conversation
42a4c34 to
d20b0aa
Compare
d20b0aa to
82d0b4a
Compare
Member
|
@teh-cmc: what's blocking this now? |
Contributor
|
@teh-cmc this is very nice, what's the status on this? |
zrezke
added a commit
to zrezke/rerun
that referenced
this pull request
Apr 26, 2023
Merged WIP albedo pointclouds from rerun-io#1487
Contributor
Author
This should be waaay easier to do now, with all the recent work that has landed with regards to texture uploads and GPU colormapping. I'll do so in another PR once I have some time. Keeping this draft open so I don't forget. |
This was referenced Jul 12, 2023
Closed
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very wip, but we're close... very close 🥵
TODO: probably go through the image cache for the albedo; there's just too many edge cases... also give a good reason to take care of #1462
23-03-02_21.32.35.patched.mp4